Bug 118092 - [CSS Shapes] New positioning model: Shape cropped to margin box
Summary: [CSS Shapes] New positioning model: Shape cropped to margin box
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL: http://dev.w3.org/csswg/css-shapes/#r...
Keywords:
Depends on: 122562
Blocks: 117898
  Show dependency treegraph
 
Reported: 2013-06-26 14:56 PDT by Bem Jones-Bey
Modified: 2013-10-10 11:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (37.27 KB, patch)
2013-10-10 09:50 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-06-26 14:56:47 PDT
Test with shapes that are larger than the margin box, and ensure they are properly clipped.

Tests should at least be:

[ ]triangular polygon with a point outside of margin box in inline direction (right side on left float, left side on right float)
[ ]triangular polygon with a point outside of margin box out of the bottom 

These should cover all the cases in the code, but will add more tests if needed.
Comment 1 Bem Jones-Bey 2013-10-10 09:50:15 PDT
Created attachment 213895 [details]
Patch
Comment 2 Alexandru Chiculita 2013-10-10 10:55:03 PDT
Comment on attachment 213895 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-10 11:21:27 PDT
Comment on attachment 213895 [details]
Patch

Clearing flags on attachment: 213895

Committed r157236: <http://trac.webkit.org/changeset/157236>
Comment 4 WebKit Commit Bot 2013-10-10 11:21:30 PDT
All reviewed patches have been landed.  Closing bug.