Bug 118081 – [CSS Shapes] New positioning model: support for rounded rectangle shape-outside

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bem Jones-Bey]

Rounded rectangle support in the new positioning model.

[Bem Jones-Bey]

This needs the borders patch to land first.

[Bem Jones-Bey]

Created attachment 207018 [details]
Patch

Add rounded rectangle tests for shape-outside

[Dean Jackson]

Comment on attachment 207018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review

> LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15
> +            // within the upper rounded corner part of the rectangle

I assume we don't pick nits for things that are imported from external repositories.

[WebKit Commit Bot]

Comment on attachment 207018 [details]
Patch

Rejecting attachment 207018 [details] from commit-queue.

New failing tests:
fast/shapes/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html
Full output: http://webkit-queues.appspot.com/results/1137718

[WebKit Commit Bot]

Created attachment 207342 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

[Bem Jones-Bey]

Comment on attachment 207018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review

>> LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15
>> +            // within the upper rounded corner part of the rectangle
> 
> I assume we don't pick nits for things that are imported from external repositories.

Actually, that's a good catch, I'll update it and post a patch for the fix. I would be more than happy to get told about nits and other issues with the imported tests in the future, so that I can update them upstream as well.

[Bem Jones-Bey]

(In reply to comment #6)
> (From update of attachment 207018 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207018&action=review
> 
> >> LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js:15
> >> +            // within the upper rounded corner part of the rectangle
> > 
> > I assume we don't pick nits for things that are imported from external repositories.
> 
> Actually, that's a good catch, I'll update it and post a patch for the fix. I would be more than happy to get told about nits and other issues with the imported tests in the future, so that I can update them upstream as well.

Looks like I'm going to have to update this patch, since apparently one test escaped deletion. I'll make this change with the updated patch.

[Bem Jones-Bey]

Created attachment 207347 [details]
Patch

Delete missed test and update nit

[WebKit Commit Bot]

Comment on attachment 207347 [details]
Patch

Clearing flags on attachment: 207347

Committed r153063: <http://trac.webkit.org/changeset/153063>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.