Bug 118078 – Polish context menus for media elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ruth Fong]

The "Controls" context menu item for media elements should be changed to a toggle-able item "Show Controls"/"Hide Controls" for clarity's sake.

[Ruth Fong]

<rdar://problem/14278960>

[Ruth Fong]

Also, change "Fullscreen" to "Full Screen".

[Ruth Fong]

Created attachment 205525 [details]
Patch

[EFL EWS Bot]

Comment on attachment 205525 [details]
Patch

Attachment 205525 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/963723

[Early Warning System Bot]

Comment on attachment 205525 [details]
Patch

Attachment 205525 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/892302

[Early Warning System Bot]

Comment on attachment 205525 [details]
Patch

Attachment 205525 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/892301

[EFL EWS Bot]

Comment on attachment 205525 [details]
Patch

Attachment 205525 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/986114

[Ruth Fong]

Created attachment 205533 [details]
Patch

[Early Warning System Bot]

Comment on attachment 205533 [details]
Patch

Attachment 205533 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/963750

[Early Warning System Bot]

Comment on attachment 205533 [details]
Patch

Attachment 205533 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/946429

[EFL EWS Bot]

Comment on attachment 205533 [details]
Patch

Attachment 205533 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/990223

[EFL EWS Bot]

Comment on attachment 205533 [details]
Patch

Attachment 205533 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/945709

[Ruth Fong]

Created attachment 205539 [details]
Patch

[Early Warning System Bot]

Comment on attachment 205539 [details]
Patch

Attachment 205539 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/869839

[Early Warning System Bot]

Comment on attachment 205539 [details]
Patch

Attachment 205539 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/948384

[Ruth Fong]

Created attachment 205542 [details]
Patch

[Eric Carlson]

Comment on attachment 205542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205542&action=review

> Source/WebCore/ChangeLog:9
> +        No new tests. media/context-menu-action.html,

Nit: I think you meant to use a comma instead of a period here.

> Source/WebKit2/ChangeLog:13
> [phone]  Ruth Fong  <[e-mail]>
> +
> +        Polish context menus for media elements
> +        https://bugs.webkit.org/show_bug.cgi?id=118078
> +        <rdar://problem/14278960>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Shared/API/c/WKContextMenuItemTypes.h:
> +        * Shared/API/c/WKSharedAPICast.h:
> +        Added new type of context menu item that allows
> +        toggling between "Show Controls" and "Hide Controls".
> +

This is not needed.

[Ruth Fong]

Created attachment 205616 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 205616 [details]
Patch

Clearing flags on attachment: 205616

Committed r152117: <http://trac.webkit.org/changeset/152117>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.