Bug 118074 – Add JSStringCreateWithCharactersNoCopy SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Add JSStringCreateWithCharactersNoCopy SPI

[Radar WebKit Bug Importer]

<rdar://problem/14279905>

[Anders Carlsson]

Created attachment 205520 [details]
Patch

[WebKit Commit Bot]

Attachment 205520 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSStringRef.cpp', u'Source/JavaScriptCore/API/JSStringRefPrivate.h', u'Source/JavaScriptCore/API/OpaqueJSString.h', u'Source/JavaScriptCore/API/tests/testapi.c', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/StringImpl.cpp', u'Source/WTF/wtf/text/StringImpl.h']" exit_code: 1
Source/WTF/wtf/text/StringImpl.h:772:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WTF/wtf/text/StringImpl.h:1365:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 205520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205520&action=review

r=me

> Source/WTF/wtf/text/StringImpl.h:774
> +        else

No else, please.

> Source/WTF/wtf/text/StringImpl.h:1367
> +        else

Ditto.

> Source/WTF/wtf/text/StringImpl.h:1373
> -    return create(m_data16, m_length);
> +    else

Boo.

[Anders Carlsson]

Committed r152052: <http://trac.webkit.org/changeset/152052>