Bug 118074 - Add JSStringCreateWithCharactersNoCopy SPI
Summary: Add JSStringCreateWithCharactersNoCopy SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-26 13:04 PDT by Anders Carlsson
Modified: 2013-06-26 16:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (18.81 KB, patch)
2013-06-26 13:17 PDT, Anders Carlsson 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-06-26 13:04:00 PDT 
Add JSStringCreateWithCharactersNoCopy SPI
Comment 1 Radar WebKit Bug Importer 2013-06-26 13:06:34 PDT 
<rdar://problem/14279905>
Comment 2 Anders Carlsson 2013-06-26 13:17:29 PDT 
Created attachment 205520 [details]
Patch
Comment 3 WebKit Commit Bot 2013-06-26 13:19:55 PDT 
Attachment 205520 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSStringRef.cpp', u'Source/JavaScriptCore/API/JSStringRefPrivate.h', u'Source/JavaScriptCore/API/OpaqueJSString.h', u'Source/JavaScriptCore/API/tests/testapi.c', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/text/StringImpl.cpp', u'Source/WTF/wtf/text/StringImpl.h']" exit_code: 1
Source/WTF/wtf/text/StringImpl.h:772:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WTF/wtf/text/StringImpl.h:1365:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2013-06-26 15:17:33 PDT 
Comment on attachment 205520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205520&action=review

r=me

> Source/WTF/wtf/text/StringImpl.h:774
> +        else

No else, please.

> Source/WTF/wtf/text/StringImpl.h:1367
> +        else

Ditto.

> Source/WTF/wtf/text/StringImpl.h:1373
> -    return create(m_data16, m_length);
> +    else

Boo.
Comment 5 Anders Carlsson 2013-06-26 16:24:21 PDT 
Committed r152052: <http://trac.webkit.org/changeset/152052>