Bug 11807 - Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed
Summary: Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 11784
  Show dependency treegraph
Reported: 2006-12-11 11:49 PST by Alexey Proskuryakov
Modified: 2006-12-11 12:27 PST (History)
0 users

See Also:

proposed patch (5.00 KB, patch)
2006-12-11 11:59 PST, Alexey Proskuryakov
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-12-11 11:49:43 PST
First part of bug 11784 - making baby steps to simplify future regression testing :)

Merging these variables uncovered an issue with event handling in DRT. Mouse clicks in native widgets would turn [NSApp currentEvent] from nil to NSLeftMouseUp forever, so lastEventIsMouseUp() started to misbehave and caused m_mouseDown to be reset to false in handleMousePressed().

I couldn't find any way to work around this issue in DRT, so I had to change WebCore (added a check to event timestamps). Luckily, the impact seems to be minor.
Comment 1 Alexey Proskuryakov 2006-12-11 11:59:10 PST
Created attachment 11804 [details]
proposed patch
Comment 2 Adam Roben (:aroben) 2006-12-11 12:01:44 PST
Comment on attachment 11804 [details]
proposed patch

Comment 3 Alexey Proskuryakov 2006-12-11 12:27:06 PST
Committed revision 18158.