Match CanvasGradient::addColorStop to the spec.

[Dongseong Hwang]

The canvas spec [1] defines addColorStop without optional arguments. This patch
removes optional attribute from addColorStop interface.

[1] http://www.w3.org/TR/2dcontext2/

[Dongseong Hwang]

Created attachment 205501 [details]
Patch

[Dongseong Hwang]

This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006

[Chris Dumez]

(In reply to comment #2)
> This patch is backported from Blink : https://chromiumcodereview.appspot.com/14798006

"cherry-pick" or "ported" would be more accurate than "backport" here :)

[Chris Dumez]

Comment on attachment 205501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review

LGTM but someone else should confirm as this is a web exposed change.

> Source/WebCore/ChangeLog:9
> +        removes optional attribute from addColorStop interface.

nit: "removes the optional keyword from addColorStop operation arguments."

[Dongseong Hwang]

(In reply to comment #4)
> (From update of attachment 205501 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205501&action=review
> 
> LGTM but someone else should confirm as this is a web exposed change.
> 
> > Source/WebCore/ChangeLog:9
> > +        removes optional attribute from addColorStop interface.
> 
> nit: "removes the optional keyword from addColorStop operation arguments."

Thank you for review! I'll fix nit :)

[Dirk Schulze]

*** Bug 118011 has been marked as a duplicate of this bug. ***

[Dirk Schulze]

Comment on attachment 205501 [details]
Patch

r=me. I hope you can still land this bug. But please fix the change log.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

This was eventually fixed in bug 160297.

*** This bug has been marked as a duplicate of bug 160297 ***