Bug 118057 - [CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
Summary: [CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 115039
  Show dependency treegraph
 
Reported: 2013-06-26 06:17 PDT by Catalin badea
Modified: 2013-07-02 00:44 PDT (History)
4 users (show)

See Also:


Attachments
patch for landing. (18.33 KB, patch)
2013-06-26 06:17 PDT, Catalin badea
badea: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-1 for win-future (869.13 KB, application/zip)
2013-06-26 21:32 PDT, Build Bot
no flags Details
fixed style errors. (18.34 KB, patch)
2013-06-27 02:30 PDT, Catalin badea
no flags Details | Formatted Diff | Diff
small change in comments. (18.34 KB, patch)
2013-06-27 14:43 PDT, Catalin badea
no flags Details | Formatted Diff | Diff
Patch (21.56 KB, patch)
2013-07-01 04:35 PDT, Catalin badea
no flags Details | Formatted Diff | Diff
Patch (21.56 KB, patch)
2013-07-01 13:14 PDT, Catalin badea
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Catalin badea 2013-06-26 06:17:37 PDT
Created attachment 205482 [details]
patch for landing.

Auto height regions use overrideLogicalHeight() in their layout process, 
this can overlap with flexbox containers trying to stretch/shrink their children.

Tests: fast/regions/autoheight-flexbox.html
Comment 1 WebKit Commit Bot 2013-06-26 08:30:44 PDT
Attachment 205482 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/regions/autoheight-flexbox-expected.html', u'LayoutTests/fast/regions/autoheight-flexbox.html', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderView.cpp']" exit_code: 1
Source/WebCore/rendering/RenderRegion.h:113:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:114:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:119:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:120:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Build Bot 2013-06-26 21:32:15 PDT
Comment on attachment 205482 [details]
patch for landing.

Attachment 205482 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/896130

New failing tests:
tables/mozilla_expected_failures/core/col_span2.html
Comment 3 Build Bot 2013-06-26 21:32:16 PDT
Created attachment 205559 [details]
Archive of layout-test-results from APPLE-EWS-1 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-1  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Catalin badea 2013-06-27 02:30:13 PDT
Created attachment 205581 [details]
fixed style errors.
Comment 5 Catalin badea 2013-06-27 14:43:56 PDT
Created attachment 205638 [details]
small change in comments.
Comment 6 Catalin badea 2013-07-01 04:35:51 PDT
Created attachment 205798 [details]
Patch
Comment 7 Dave Hyatt 2013-07-01 12:52:43 PDT
Comment on attachment 205798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205798&action=review

Looks fine. Minor quibble.

> Source/WebCore/rendering/RenderRegion.cpp:58
> +    , m_computedAutoHeight(0)
> +    , m_hasComputedAutoHeight(false)

I would flip these.

> Source/WebCore/rendering/RenderRegion.h:214
> +    LayoutUnit m_computedAutoHeight;
> +    bool m_hasComputedAutoHeight : 1;

I would flip these to put m_hasComputedAutoHeight with the other bits.
Comment 8 Catalin badea 2013-07-01 13:14:13 PDT
Created attachment 205832 [details]
Patch
Comment 9 Dave Hyatt 2013-07-01 13:20:02 PDT
Comment on attachment 205832 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2013-07-02 00:43:58 PDT
Comment on attachment 205832 [details]
Patch

Clearing flags on attachment: 205832

Committed r152281: <http://trac.webkit.org/changeset/152281>
Comment 11 WebKit Commit Bot 2013-07-02 00:44:00 PDT
All reviewed patches have been landed.  Closing bug.