Bug 118057 – [CSS-Regions] OverrideLogicalHeight used by both regions and flexbox

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Catalin badea]

Created attachment 205482 [details]
patch for landing.

Auto height regions use overrideLogicalHeight() in their layout process, 
this can overlap with flexbox containers trying to stretch/shrink their children.

Tests: fast/regions/autoheight-flexbox.html

[WebKit Commit Bot]

Attachment 205482 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/regions/autoheight-flexbox-expected.html', u'LayoutTests/fast/regions/autoheight-flexbox.html', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderView.cpp']" exit_code: 1
Source/WebCore/rendering/RenderRegion.h:113:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:114:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:119:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderRegion.h:120:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 205482 [details]
patch for landing.

Attachment 205482 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/896130

New failing tests:
tables/mozilla_expected_failures/core/col_span2.html

[Build Bot]

Created attachment 205559 [details]
Archive of layout-test-results from APPLE-EWS-1 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-1  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[Catalin badea]

Created attachment 205581 [details]
fixed style errors.

[Catalin badea]

Created attachment 205638 [details]
small change in comments.

[Catalin badea]

Created attachment 205798 [details]
Patch

[Dave Hyatt]

Comment on attachment 205798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205798&action=review

Looks fine. Minor quibble.

> Source/WebCore/rendering/RenderRegion.cpp:58
> +    , m_computedAutoHeight(0)
> +    , m_hasComputedAutoHeight(false)

I would flip these.

> Source/WebCore/rendering/RenderRegion.h:214
> +    LayoutUnit m_computedAutoHeight;
> +    bool m_hasComputedAutoHeight : 1;

I would flip these to put m_hasComputedAutoHeight with the other bits.

[Catalin badea]

Created attachment 205832 [details]
Patch

[Dave Hyatt]

Comment on attachment 205832 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 205832 [details]
Patch

Clearing flags on attachment: 205832

Committed r152281: <http://trac.webkit.org/changeset/152281>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.