Bug 118054 - Use & instead of | in the value of [CallWith]
Summary: Use & instead of | in the value of [CallWith]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-26 03:45 PDT by Chris Dumez
Modified: 2013-06-28 01:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.10 KB, patch)
2013-06-26 04:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.19 KB, patch)
2013-06-27 23:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-26 03:45:01 PDT 
[CallWith=ScriptExecutionContext|ScriptState] meant that both the ScriptExecutionContext AND the ScriptState would be passed as arguments to the implementation (not one OR the other).

We should use [CallWith=ScriptExecutionContext&ScriptState] for clarity.
Comment 1 Chris Dumez 2013-06-26 04:08:58 PDT 
Created attachment 205468 [details]
Patch
Comment 2 Kentaro Hara 2013-06-26 04:45:43 PDT 
Comment on attachment 205468 [details]
Patch

Makes sense.
Comment 3 Chris Dumez 2013-06-27 23:23:42 PDT 
Created attachment 205670 [details]
Patch
Comment 4 WebKit Commit Bot 2013-06-28 01:20:52 PDT 
Comment on attachment 205670 [details]
Patch

Clearing flags on attachment: 205670

Committed r152154: <http://trac.webkit.org/changeset/152154>
Comment 5 WebKit Commit Bot 2013-06-28 01:20:54 PDT 
All reviewed patches have been landed.  Closing bug.