Bug 118025 - [CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
Summary: [CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: BlinkMergeCandidate
Depends on: 118255
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-25 21:10 PDT by Ryosuke Niwa
Modified: 2013-11-07 02:51 PST (History)
19 users (show)

See Also:

Attachments
Patch (6.37 KB, patch)
2013-11-06 09:42 PST, Sergio Villar Senin 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 21:10:05 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/486ed9f6fb9e9d72509c94a173092ac6370c35da

The case of <track-list> without a <track-size> was properly handled
but that's because style resolution had to account for the parsing
being not totally right.

This refactoring will help with implementing parsing for
<repeat-function> as the code matches the specification more closely.
Comment 1 Sergio Villar Senin 2013-11-06 09:42:21 PST 
Created attachment 216186 [details]
Patch
Comment 2 Andreas Kling 2013-11-07 01:42:30 PST 
Comment on attachment 216186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216186&action=review

r=me with a tiny improvement:

> Source/WebCore/css/CSSParser.cpp:5029
> +        values->append(name);

values->append(name.release());
Comment 3 Sergio Villar Senin 2013-11-07 02:51:28 PST 
Committed r158839: <http://trac.webkit.org/changeset/158839>