Merge https://chromium.googlesource.com/chromium/blink/+/ecd837f94996a20fdb8798e24f26cf6edea2a423 Some of these casts were to overly specific types, like casting to HTMLFrameElementBase* just to call getAttribute. In other cases we can cast to a more generic type like HTMLTextFormControlElement to avoid the extra cases the code originally had.
Created attachment 205444 [details] Cleanup
Comment on attachment 205444 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=205444&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1647 > + return toHTMLTextFormControlElement(node)->value(); Isn't this a bad cast for input type=checkbox for instance?
(In reply to comment #2) > (From update of attachment 205444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205444&action=review > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1647 > > + return toHTMLTextFormControlElement(node)->value(); > > Isn't this a bad cast for input type=checkbox for instance? No. Both HTMLInputElement and HTMLTextAreaElement inherit from HTMLTextFormControlElement.
Comment on attachment 205444 [details] Cleanup Clearing flags on attachment: 205444 Committed r151990: <http://trac.webkit.org/changeset/151990>
All reviewed patches have been landed. Closing bug.