WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
118018
Remove unneeded static_casts from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=118018
Summary
Remove unneeded static_casts from SelectorChecker
Ryosuke Niwa
Reported
2013-06-25 20:14:50 PDT
Merge
https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367
SelectorChecker::checkOne casts to StyledElement just to call classNames, but this method is on Element so there's no reason for this. The cast here also looks pretty suspect. The method also casts to HTMLFrameElementBase to call containsFullScreenElement which is also on Element so the cast can be removed.
Attachments
Merges the patch
(2.38 KB, patch)
2013-06-25 20:16 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-06-25 20:16:29 PDT
Created
attachment 205442
[details]
Merges the patch
WebKit Commit Bot
Comment 2
2013-06-26 11:07:28 PDT
Comment on
attachment 205442
[details]
Merges the patch Clearing flags on attachment: 205442 Committed
r152001
: <
http://trac.webkit.org/changeset/152001
>
WebKit Commit Bot
Comment 3
2013-06-26 11:07:33 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug