Bug 118018 - Remove unneeded static_casts from SelectorChecker
Summary: Remove unneeded static_casts from SelectorChecker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-25 20:14 PDT by Ryosuke Niwa
Modified: 2013-06-26 11:07 PDT (History)
11 users (show)

See Also:

Attachments
Merges the patch (2.38 KB, patch)
2013-06-25 20:16 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 20:14:50 PDT 
Merge https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367

SelectorChecker::checkOne casts to StyledElement just to call classNames, but
this method is on Element so there's no reason for this. The cast here also
looks pretty suspect. The method also casts to HTMLFrameElementBase to call
containsFullScreenElement which is also on Element so the cast can be removed.
Comment 1 Ryosuke Niwa 2013-06-25 20:16:29 PDT 
Created attachment 205442 [details]
Merges the patch
Comment 2 WebKit Commit Bot 2013-06-26 11:07:28 PDT 
Comment on attachment 205442 [details]
Merges the patch

Clearing flags on attachment: 205442

Committed r152001: <http://trac.webkit.org/changeset/152001>
Comment 3 WebKit Commit Bot 2013-06-26 11:07:33 PDT 
All reviewed patches have been landed.  Closing bug.