Bug 118017 - editing/selection/doubleclick-crash.html can be flaky
Summary: editing/selection/doubleclick-crash.html can be flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-25 20:10 PDT by Ryosuke Niwa
Modified: 2013-06-26 09:29 PDT (History)
6 users (show)

See Also:


Attachments
Fixes the bug (1.08 KB, patch)
2013-06-25 20:12 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-4 for win-future (802.45 KB, application/zip)
2013-06-26 02:17 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 20:10:43 PDT
Merge https://chromium.googlesource.com/chromium/blink/+/45ac882064589ac41a63762905f0618fc035cd44

The test failure is caused by firing timeout event before document loaded.

More specifically, step1() tries to set caret position by mouse down, but it doesn't set caret position, because there are no nodes. This reason why below lines are missed in failed result:

EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 5 of #text > PRE > BODY > HTML > #document to 5 of #text > PRE > BODY > HTML > #document toDOMRange:range from 5 of #text > PRE > BODY > HTML > #document to 6 of #text > PRE > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
Comment 1 Ryosuke Niwa 2013-06-25 20:12:37 PDT
Created attachment 205441 [details]
Fixes the bug
Comment 2 Build Bot 2013-06-26 02:17:39 PDT
Comment on attachment 205441 [details]
Fixes the bug

Attachment 205441 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/952267

New failing tests:
fast/frames/seamless/seamless-nested-crash.html
Comment 3 Build Bot 2013-06-26 02:17:41 PDT
Created attachment 205463 [details]
Archive of layout-test-results from APPLE-EWS-4 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-4  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 WebKit Commit Bot 2013-06-26 09:29:23 PDT
Comment on attachment 205441 [details]
Fixes the bug

Clearing flags on attachment: 205441

Committed r151993: <http://trac.webkit.org/changeset/151993>
Comment 5 WebKit Commit Bot 2013-06-26 09:29:24 PDT
All reviewed patches have been landed.  Closing bug.