Bug 118016 - Remove unused attachChildrenLazily method and make attach/detachChildren private
Summary: Remove unused attachChildrenLazily method and make attach/detachChildren private
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-25 20:08 PDT by Ryosuke Niwa
Modified: 2013-06-28 17:02 PDT (History)
10 users (show)

See Also:

Attachments
Merges the patch (4.02 KB, patch)
2013-06-25 20:08 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-25 20:08:01 PDT 
Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0

No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.

In doing this I realized that attachChildrenLazily is not used and can be removed.

I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.
Comment 1 Ryosuke Niwa 2013-06-25 20:08:48 PDT 
Created attachment 205440 [details]
Merges the patch
Comment 2 WebKit Commit Bot 2013-06-28 17:02:16 PDT 
Comment on attachment 205440 [details]
Merges the patch

Clearing flags on attachment: 205440

Committed r152197: <http://trac.webkit.org/changeset/152197>
Comment 3 WebKit Commit Bot 2013-06-28 17:02:20 PDT 
All reviewed patches have been landed.  Closing bug.