RESOLVED FIXED 118012
Do not consider title from non-css stylesheet for preferred set 
https://bugs.webkit.org/show_bug.cgi?id=118012
Summary Do not consider title from non-css stylesheet for preferred set
Ryosuke Niwa
Reported 2013-06-25 19:30:37 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/ac653f351a222c4ee80ddd656aaaf06c07d87125 Do not consider title from non-css stylesheet for preferred set. Title on a style element can be used to select the preferred stylesheet set. If the type attribute of the style element is not text/css, the title should never be set as the key for the preferred stylesheet set.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-08-20 17:45:17 PDT
I took test cases from the Chrome / Blink commit: Test Case - style-preferred-stylesheet-01.html - https://jsfiddle.net/v9t5rf81/show *** Safari 15.6.1 on macOS 12.5.1 *** Text is shown in red *** Safari Technology Preview 151 *** Text is shown in red *** Chrome Canary 106 *** Text is shown in "black" - Expected result *** Firefox Nightly 105 *** Text is shown in "black" - Expected result ____ Test Case - style-preferred-stylesheet-02.html - https://jsfiddle.net/yxLba59v/show *** Safari 15.6.1 on macOS 12.5.1 *** Text is shown in "green" - Expected result *** Safari Technology Preview 151 *** Text is shown in "green" - Expected result *** Chrome Canary 106 *** Text is shown in "green" - Expected result *** Firefox Nightly 105 *** Text is shown in "green" - Expected result ______ Safari is failing one of the two test. Just wanted to share updated results. Thanks!
Radar WebKit Bug Importer
Comment 2 2022-08-20 18:02:03 PDT
<rdar://problem/98934685>
Brent Fulgham
Comment 3 2022-08-20 18:03:26 PDT
@Vitor: could you look into this one?
Ahmad Saleem
Comment 4 2022-08-20 23:10:53 PDT
Webkit GitHub Source: https://github.com/WebKit/WebKit/blob/a39b520b8e0ca63489db7a45fe19181a33fac903/Source/WebCore/style/StyleScope.cpp#L373 _____ if (!enabledViaScript && !title.isEmpty() && m_preferredStylesheetSetName.isEmpty()) { ___ Blink Patch modifying: if (!enabledViaScript && sheet && !title.isEmpty()) {
Ryosuke Niwa
Comment 5 2022-08-20 23:30:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3512
EWS
Comment 6 2022-08-21 12:06:36 PDT
Committed 253632@main (4e99fbf6f75a): <https://commits.webkit.org/253632@main> Reviewed commits have been landed. Closing PR #3512 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.