Bug 118002 - [CSS Shapes] Clear overflowing line's segments in pushShapeContentOverflowBelowTheContentBox
Summary: [CSS Shapes] Clear overflowing line's segments in pushShapeContentOverflowBel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 89256
  Show dependency tree / graph
 
Reported: 2013-06-25 15:39 PDT by Zoltan Horvath
Modified: 2013-07-19 10:44 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (7.06 KB, patch)
2013-06-25 15:47 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
updated patch after r152800 (7.07 KB, patch)
2013-07-17 14:54 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-06-25 15:39:49 PDT 
When the last line in the shape overlaps with the shape bottom boundaries we need to clear the computed segments. (We need to compute the segments anyway, since shape-outside's code uses the same code path to determine its segments and the line containing is not a requirement in that case.) Rather then doing the job in RenderBlock::LineBreaker::nextLineBreak I moved the functionality to its correct place to pushShapeContentOverflowBelowTheContentBox. Now all the overflow related functionality is located in one function.
Comment 1 Zoltan Horvath 2013-06-25 15:47:44 PDT 
Created attachment 205425 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-07-17 14:54:35 PDT 
Created attachment 206917 [details]
updated patch after r152800
Comment 3 Dave Hyatt 2013-07-19 10:21:56 PDT 
Comment on attachment 206917 [details]
updated patch after r152800 

r=me
Comment 4 WebKit Commit Bot 2013-07-19 10:44:52 PDT 
Comment on attachment 206917 [details]
updated patch after r152800 

Clearing flags on attachment: 206917

Committed r152906: <http://trac.webkit.org/changeset/152906>
Comment 5 WebKit Commit Bot 2013-07-19 10:44:54 PDT 
All reviewed patches have been landed.  Closing bug.