Bug 117996 - CSSRuleList.cpp and CSSGroupingRule.cpp should include <wtf/MemoryInstrumentationVector.h>
Summary: CSSRuleList.cpp and CSSGroupingRule.cpp should include <wtf/MemoryInstrumenta...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 09:07 PDT by asharif.tools
Modified: 2013-06-25 10:42 PDT (History)
13 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2013-06-25 09:17 PDT, asharif.tools 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description asharif.tools 2013-06-25 09:07:56 PDT 
CSSRuleList.cpp and CSSGroupingRule.cpp use:

void WTF::reportMemoryUsage<WTF::RefPtr<WebCore::CSSRule>, 0ul>(WTF::Vector<WTF::RefPtr<WebCore::CSSRule>, 0ul> const*, WTF::MemoryObjectInfo*)

but do not include the template header that defines this function.

This gives a linker error when building with -fprofile-generate.

The fix is simple:


Index: Source/core/css/CSSGroupingRule.cpp
===================================================================
--- Source/core/css/CSSGroupingRule.cpp	(revision 152906)
+++ Source/core/css/CSSGroupingRule.cpp	(working copy)
@@ -32,6 +32,7 @@
 
 #include "core/css/CSSGroupingRule.h"
 
+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSParser.h"
 #include "core/css/CSSRuleList.h"
 #include "core/css/CSSStyleSheet.h"
Index: Source/core/css/CSSRuleList.cpp
===================================================================
--- Source/core/css/CSSRuleList.cpp	(revision 152906)
+++ Source/core/css/CSSRuleList.cpp	(working copy)
@@ -22,6 +22,7 @@
 #include "config.h"
 #include "core/css/CSSRuleList.h"
 
+#include <wtf/MemoryInstrumentationVector.h>
 #include "core/css/CSSRule.h"
 
 namespace WebCore {
Comment 1 asharif.tools 2013-06-25 09:17:40 PDT 
Created attachment 205409 [details]
Patch
Comment 2 asharif.tools 2013-06-25 09:18:54 PDT 
Comment on attachment 205409 [details]
Patch

Please take a look at the patch and give me some feedback.
Comment 3 Build Bot 2013-06-25 09:20:17 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/869796
Comment 4 EFL EWS Bot 2013-06-25 09:20:26 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/948246
Comment 5 Early Warning System Bot 2013-06-25 09:21:49 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/976104
Comment 6 EFL EWS Bot 2013-06-25 09:21:59 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/976105
Comment 7 Early Warning System Bot 2013-06-25 09:23:28 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/976106
Comment 8 kov's GTK+ EWS bot 2013-06-25 09:29:39 PDT 
Comment on attachment 205409 [details]
Patch

Attachment 205409 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/948248
Comment 9 asharif.tools 2013-06-25 09:30:59 PDT 
Sorry about the noise. This problem is only in Blink, not in WebKit.