Bug 117984 - Rearrange the code of FrameWin
Summary: Rearrange the code of FrameWin
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows 7
: P2 Normal
Assignee: Patrick R. Gansterer
Depends on:
Blocks: 117988
  Show dependency treegraph
Reported: 2013-06-25 05:48 PDT by Patrick R. Gansterer
Modified: 2013-08-01 09:22 PDT (History)
2 users (show)

See Also:

Patch (8.09 KB, patch)
2013-06-25 05:55 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (8.61 KB, patch)
2013-06-25 06:02 PDT, Patrick R. Gansterer
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.72 KB, patch)
2013-08-01 05:36 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-06-25 05:48:46 PDT
Rearrange the code of FrameWin
Comment 1 Patrick R. Gansterer 2013-06-25 05:55:21 PDT
Created attachment 205390 [details]
Comment 2 WebKit Commit Bot 2013-06-25 05:56:22 PDT
Attachment 205390 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/win/FrameCGWin.cpp', u'Source/WebCore/page/win/FrameCairoWin.cpp', u'Source/WebCore/page/win/FrameWin.cpp', u'Source/WebCore/page/win/FrameWin.h', u'Source/WebKit/win/WebView.cpp']" exit_code: 1
Source/WebCore/page/win/FrameWin.cpp:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2013-06-25 06:02:25 PDT
Created attachment 205392 [details]
Comment 4 Brent Fulgham 2013-07-30 09:27:00 PDT
Comment on attachment 205392 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=205392&action=review

I think the imageFromRect method should take a const Frame* argument.  Otherwise, this looks good to me.  Please correct the const when you land it.

> Source/WebCore/page/win/FrameCGWin.cpp:52
> +PassOwnPtr<HBITMAP> imageFromRect(Frame* frame, IntRect& ir)

Why remove the 'const' from the Frame* argument?
Comment 5 Brent Fulgham 2013-07-30 09:28:15 PDT
Also, I think the ChangeLog should be a bit more descriptive, since you:
1. Shared more code between WinCairo and Windows.
2. Made use of our safer pointer types.

Also, please fix the spaces in FrameWin.cpp when you land.
Comment 6 Patrick R. Gansterer 2013-08-01 05:36:29 PDT
Created attachment 207914 [details]
Patch for landing
Comment 7 Brent Fulgham 2013-08-01 09:00:33 PDT
Comment on attachment 207914 [details]
Patch for landing

Comment 8 WebKit Commit Bot 2013-08-01 09:22:00 PDT
Comment on attachment 207914 [details]
Patch for landing

Clearing flags on attachment: 207914

Committed r153586: <http://trac.webkit.org/changeset/153586>
Comment 9 WebKit Commit Bot 2013-08-01 09:22:01 PDT
All reviewed patches have been landed.  Closing bug.