Bug 117980 - Adopt is/toHTMLAreaElement for code cleanup
Summary: Adopt is/toHTMLAreaElement for code cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 05:21 PDT by Kangil Han
Modified: 2013-06-26 10:24 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.08 KB, patch)
2013-06-25 05:24 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2013-06-26 06:23 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (763.35 KB, application/zip)
2013-06-26 08:18 PDT, WebKit Commit Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2013-06-25 05:21:36 PDT 
Adopt is/toHTMLAreaElement for code cleanup
Comment 1 Kangil Han 2013-06-25 05:24:20 PDT 
Created attachment 205384 [details]
Patch
Comment 2 Antonio Gomes 2013-06-26 05:40:08 PDT 
Comment on attachment 205384 [details]
Patch

I think toHTMLAreaElement makes sense, given that there are other similar toXXX functions around.

I am not sure isHTMLAreaElement does, though.

In the same line now you have things like if (isHTMLAreaElement() ||bleh->hasTagName(blah))
Comment 3 Kangil Han 2013-06-26 05:54:09 PDT 
(In reply to comment #2)
> (From update of attachment 205384 [details])
> I think toHTMLAreaElement makes sense, given that there are other similar toXXX functions around.
> 
> I am not sure isHTMLAreaElement does, though.
> 
> In the same line now you have things like if (isHTMLAreaElement() ||bleh->hasTagName(blah))

Don't worry.
I've made patches to adopt is/toFooElement for all FooElements. :)
As patches are landed, we won't see blah things you mentioned. ;)
Comment 4 Antonio Gomes 2013-06-26 06:09:21 PDT 
Comment on attachment 205384 [details]
Patch

Ok
Comment 5 Kangil Han 2013-06-26 06:10:40 PDT 
(In reply to comment #4)
> (From update of attachment 205384 [details])
> Ok

Thx!
Comment 6 WebKit Commit Bot 2013-06-26 06:11:37 PDT 
Comment on attachment 205384 [details]
Patch

Rejecting attachment 205384 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 205384, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
tTestResult.cpp
Hunk #1 FAILED at 29.
Hunk #2 FAILED at 511.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/rendering/HitTestResult.cpp.rej
patching file Source/WebCore/rendering/RenderImage.cpp
patching file Source/WebKit/blackberry/Api/WebPage.cpp
patching file Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antonio Gomes']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/965833
Comment 7 Kangil Han 2013-06-26 06:23:29 PDT 
Created attachment 205483 [details]
Patch
Comment 8 WebKit Commit Bot 2013-06-26 08:18:14 PDT 
Comment on attachment 205483 [details]
Patch

Rejecting attachment 205483 [details] from commit-queue.

New failing tests:
media/track/media-element-enqueue-event-crash.html
Full output: http://webkit-queues.appspot.com/results/930472
Comment 9 WebKit Commit Bot 2013-06-26 08:18:15 PDT 
Created attachment 205495 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 10 Kangil Han 2013-06-26 08:46:03 PDT 
Try one more since this patch doesn't touch media stuff. :)
Comment 11 WebKit Commit Bot 2013-06-26 10:24:07 PDT 
Comment on attachment 205483 [details]
Patch

Clearing flags on attachment: 205483

Committed r151996: <http://trac.webkit.org/changeset/151996>
Comment 12 WebKit Commit Bot 2013-06-26 10:24:09 PDT 
All reviewed patches have been landed.  Closing bug.