Bug 117979 - [GTK][WK2][Stable] Cannot make debug builds of the stable branch
Summary: [GTK][WK2][Stable] Cannot make debug builds of the stable branch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-25 05:06 PDT by Alberto Garcia
Modified: 2013-06-26 01:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2013-06-25 05:08 PDT, Alberto Garcia 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-06-25 05:06:44 PDT 
Here's the error message:

Source/WebKit2/PluginProcess/unix/Programs_WebKitPluginProcess-PluginProcessMainUnix.o: In function `webkitXError':
Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp:68: undefined reference to `WebKit::LogPlugins'
Source/WebKit2/Shared/Programs_WebKitPluginProcess-WebKit2Initialize.o: In function `WebKit::InitializeWebKit2()':
Source/WebKit2/Shared/WebKit2Initialize.cpp:53: undefined reference to `WebKit::initializeLogChannelsIfNecessary()'
Comment 1 Alberto Garcia 2013-06-25 05:08:51 PDT 
Created attachment 205383 [details]
Patch
Comment 2 Zan Dobersek 2013-06-25 07:27:51 PDT 
Comment on attachment 205383 [details]
Patch

Alternatively you could add libWebKit2Platform.la to the list of Programs_WebKitPluginProcess_LDADD. That's what solves the issue in trunk, it seems.
Comment 3 Carlos Garcia Campos 2013-06-25 10:05:31 PDT 
In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC
Comment 4 Zan Dobersek 2013-06-25 10:08:25 PDT 
(In reply to comment #3)
> In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC

Correct, libWebKit2Platform didn't make it into the 2.0 branch, so I guess the proposed patch is just fine.
Comment 5 Alberto Garcia 2013-06-25 22:56:57 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > In trunk we build libWebKit2Platform as a separate library and the plugin process links to it, IIRC
> 
> Correct, libWebKit2Platform didn't make it into the 2.0 branch, so I guess the proposed patch is just fine.

That was the idea.
Comment 6 Carlos Garcia Campos 2013-06-26 01:17:27 PDT 
Merged in stable branch <http://trac.webkit.org/changeset/151983>