Bug 117969 - Don't snapshot plug-ins that come from the same host as the page
Summary: Don't snapshot plug-ins that come from the same host as the page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 20:38 PDT by Dean Jackson
Modified: 2013-06-25 14:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2013-06-24 20:41 PDT, Dean Jackson 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (632.08 KB, application/zip)
2013-06-25 00:44 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-06-24 20:38:20 PDT 
Typically if a page has a plug-in that is served from the same host, it's content that is important to the site. Make sure we don't snapshot that content.

<rdar://problem/12885400>
Comment 1 Dean Jackson 2013-06-24 20:41:09 PDT 
Created attachment 205359 [details]
Patch
Comment 2 Jon Lee 2013-06-24 21:10:23 PDT 
Comment on attachment 205359 [details]
Patch

LGTM. r=me
Comment 3 Build Bot 2013-06-25 00:43:59 PDT 
Comment on attachment 205359 [details]
Patch

Attachment 205359 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/960850

New failing tests:
svg/batik/filters/feTile.svg
Comment 4 Build Bot 2013-06-25 00:44:00 PDT 
Created attachment 205370 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 5 Tim Horton 2013-06-25 12:52:07 PDT 
Comment on attachment 205359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205359&action=review

r+ but talk to Darin about impact, as discussed.

> Source/WebCore/ChangeLog:14
> +            Add a test that compares the plug-in's URL against the main page's

This looks indented strangely.
Comment 6 Dean Jackson 2013-06-25 14:49:04 PDT 
Committed r151971: <http://trac.webkit.org/changeset/151971>