Bug 117968 – [EFL] Add a script to install dependencies.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Byungwoo Lee]

EFL doesn't have a script to install basic dependencies.
(GTK has Tool/gtk/install-dependencies)

[Byungwoo Lee]

Created attachment 205355 [details]
Patch

[Byungwoo Lee]

Created attachment 205357 [details]
Patch

[Sergio Correia (qrwteyrutiyoup)]

Looks cool, but why not add support for Fedora (yum) as well, since you seem to be basing this work on the existing script for the Gtk port which supports them both?

[Byungwoo Lee]

(In reply to comment #3)
> Looks cool, but why not add support for Fedora (yum) as well, since you seem to be basing this work on the existing script for the Gtk port which supports them both?

Yes, I copied the script from GTK, but I don't have an environment for yum, so I remained it for the other one who needs it.
(And there is no guide for the yum packaging in current wiki page)

How do you think about it?

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #4)
> (In reply to comment #3)
> > Looks cool, but why not add support for Fedora (yum) as well, since you seem to be basing this work on the existing script for the Gtk port which supports them both?
> 
> Yes, I copied the script from GTK, but I don't have an environment for yum, so I remained it for the other one who needs it.
> (And there is no guide for the yum packaging in current wiki page)
> 
> How do you think about it?

Ah, okay. I didn't know about the wiki not mentioning yum - gotta get more familiar with it. In this case, I agree that someone can add it later, if needed :)

[Chris Dumez]

Comment on attachment 205357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205357&action=review

Good addition, r=me with nit.

> Tools/efl/install-dependencies:72
> +        gstreamer-dbus-media-service

Please remove this one. I doubt this is needed now that gstreamer 1.0 is part of jhbuild.

[Byungwoo Lee]

(In reply to comment #6)
> (From update of attachment 205357 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205357&action=review
> 
> Good addition, r=me with nit.
> 
> > Tools/efl/install-dependencies:72
> > +        gstreamer-dbus-media-service
> 
> Please remove this one. I doubt this is needed now that gstreamer 1.0 is part of jhbuild.

Ok. Will remove it.

[Byungwoo Lee]

Created attachment 205375 [details]
Patch

[Byungwoo Lee]

(In reply to comment #8)
> Created an attachment (id=205375) [details]
> Patch

Oops sorry, will upload again with reviewed comment.

[Byungwoo Lee]

Created attachment 205376 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 205376 [details]
Patch

Clearing flags on attachment: 205376

Committed r151961: <http://trac.webkit.org/changeset/151961>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryuan Choi]

(In reply to comment #12)
> All reviewed patches have been landed.  Closing bug.

Will you update https://trac.webkit.org/wiki/EFLWebKit ?

[Byungwoo Lee]

(In reply to comment #13)
> (In reply to comment #12)
> > All reviewed patches have been landed.  Closing bug.
> 
> Will you update https://trac.webkit.org/wiki/EFLWebKit ?

Sure, I'll update it.

[Laszlo Gombos]

Nice. Can the build bot run this, so that it gets tested and we can just add a dependency to the build bot as well by changing this script ?

[Chris Dumez]

(In reply to comment #15)
> Nice. Can the build bot run this, so that it gets tested and we can just add a dependency to the build bot as well by changing this script ?

The script would probably have to be updated to be non-interactive then. Also, I'm not sure it is feasible because the script requires root privileges.