Bug 117956 - [BlackBerry] Only resume root layer commits for visible WebPages
Summary: [BlackBerry] Only resume root layer commits for visible WebPages
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
Depends on:
Reported: 2013-06-24 15:45 PDT by Jakob Petsovits
Modified: 2013-06-25 08:06 PDT (History)
5 users (show)

See Also:

Patch (4.46 KB, patch)
2013-06-24 15:48 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-06-24 15:45:26 PDT
In r150629, the code from that change introduced to suspend and resume root layer commits would not take into account whether the page is actually visible.

Because application activation state is usually conveyed to all or any WebPages, this would mean on transitioning into an active application state, we were resuming root layer commits that might have previously been disabled for visibility reasons.

The patch below fixes this by going through a single function that knows by itself whether to suspend or resume root layer commits, so the calling code doesn't have a chance to get it wrong.
Comment 1 Jakob Petsovits 2013-06-24 15:48:42 PDT
Created attachment 205337 [details]
Comment 2 George Staikos 2013-06-24 16:32:33 PDT
Comment on attachment 205337 [details]

This looks cleaner too.
Comment 3 WebKit Commit Bot 2013-06-24 17:06:18 PDT
Comment on attachment 205337 [details]

Clearing flags on attachment: 205337

Committed r151936: <http://trac.webkit.org/changeset/151936>
Comment 4 WebKit Commit Bot 2013-06-24 17:06:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Jakob Petsovits 2013-06-25 08:06:16 PDT
Appendix: See https://bugs.webkit.org/show_bug.cgi?id=115245 for the original patch that got fixed up by this one here.