Bug 117949 - WebKit should link to opengl32.lib on Windows
Summary: WebKit should link to opengl32.lib on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P4 Trivial
Assignee: Nobody
Depends on:
Reported: 2013-06-24 14:50 PDT by Alex Christensen
Modified: 2013-06-24 17:15 PDT (History)
2 users (show)

See Also:

Patch (2.42 KB, patch)
2013-06-24 14:52 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-24 14:50:44 PDT
Linking to opengl32.lib will allow enabling WebGL, but it won't change anything with WebGL not enabled because it currently links successfully without it.
Comment 1 Alex Christensen 2013-06-24 14:52:22 PDT
Created attachment 205329 [details]
Comment 2 Brent Fulgham 2013-06-24 15:11:53 PDT
Comment on attachment 205329 [details]

Looks fine.  Let's allow the EWS to run on it, then land it if it's fine.
Comment 3 Alex Christensen 2013-06-24 17:05:50 PDT
EWS has had its chance.  I can apply the patch, even if the windows bot can't.  I'm going to cq+ it and we'll see if it gets through the commit queue.  We can roll it out if it breaks the build, but I've built successfully with this.
Comment 4 WebKit Commit Bot 2013-06-24 17:15:38 PDT
Comment on attachment 205329 [details]

Clearing flags on attachment: 205329

Committed r151937: <http://trac.webkit.org/changeset/151937>
Comment 5 WebKit Commit Bot 2013-06-24 17:15:39 PDT
All reviewed patches have been landed.  Closing bug.