Bug 117943 - [WK2] Make sure m_iconDatabaseImpl is not null before closing it
Summary: [WK2] Make sure m_iconDatabaseImpl is not null before closing it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-24 13:19 PDT by Nick Diego Yamane (diegoyam)
Modified: 2013-06-24 15:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2013-06-24 13:24 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2013-06-24 15:23 PDT, Nick Diego Yamane (diegoyam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-06-24 13:19:05 PDT 
Make sure m_iconDatabaseImpl is not null before closing it
Comment 1 Nick Diego Yamane (diegoyam) 2013-06-24 13:24:15 PDT 
Created attachment 205321 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-06-24 14:27:36 PDT 
Is this a crash observed in the field, or when running tests?
Comment 3 Nick Diego Yamane (diegoyam) 2013-06-24 15:22:27 PDT 
Since r150474 WebIconDatabase is closed unconditionally in TestController destructor, in that case WebKitTestRunner crashes when no icon database path is set. This misbehavior was observed in ports such as efl and nix.
Comment 4 Nick Diego Yamane (diegoyam) 2013-06-24 15:23:36 PDT 
Created attachment 205333 [details]
Patch

proposed patch
Comment 5 WebKit Commit Bot 2013-06-24 15:50:01 PDT 
Comment on attachment 205333 [details]
Patch

Clearing flags on attachment: 205333

Committed r151932: <http://trac.webkit.org/changeset/151932>
Comment 6 WebKit Commit Bot 2013-06-24 15:50:03 PDT 
All reviewed patches have been landed.  Closing bug.