Bug 117938 - Potential crash when in-band track is removed
Summary: Potential crash when in-band track is removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-24 09:18 PDT by Eric Carlson
Modified: 2013-06-24 10:13 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (1.39 KB, patch)
2013-06-24 09:26 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-06-24 09:18:07 PDT 
InbandTextTrack::willRemoveTextTrackPrivate may be called after the owning HTMLMediaElement has been cleared because the media engine and the media element do not operate in sync. In this case, the media element has already dealt with the track removal so the notification from the media engine is not needed.
Comment 1 Radar WebKit Bug Importer 2013-06-24 09:23:49 PDT 
<rdar://problem/14246763>
Comment 2 Eric Carlson 2013-06-24 09:26:27 PDT 
Created attachment 205302 [details]
Proposed patch
Comment 3 Jer Noble 2013-06-24 09:36:45 PDT 
Comment on attachment 205302 [details]
Proposed patch

Null checks ftw! r=me.
Comment 4 Eric Carlson 2013-06-24 10:13:10 PDT 
https://trac.webkit.org/r151916