Bug 117930 – Update AbstractWorker, Worker and SharedWorker to match the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Update AbstractWorker, Worker and SharedWorker to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker

Worker and SharedWorker should no longer inherit from AbstractWorker. Web IDL 'implements'
statements should be used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.

[Chris Dumez]

Created attachment 205287 [details]
Patch

[Kentaro Hara]

Comment on attachment 205287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review

> Source/WebCore/workers/AbstractWorker.idl:-36
> -    CustomToJSObject,

Why can you remove this?

[Chris Dumez]

Comment on attachment 205287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review

>> Source/WebCore/workers/AbstractWorker.idl:-36
>> -    CustomToJSObject,
> 
> Why can you remove this?

This basically declares the following in JSAbstractWorker.h but don't generate its implementation in JSAbstractWorker.cpp:
JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, AbstractWorker*);

It can be removed for 2 reasons:
- Its implementation is not provided anywhere and it likely build only because it is not used.
- Now that AbstractWorker acts as a partial interface, JSAbstractWorker.* are now empty anyway so this attribute would have no impact whatsoever.

[Kentaro Hara]

Comment on attachment 205287 [details]
Patch

Makes sense.

[WebKit Commit Bot]

Comment on attachment 205287 [details]
Patch

Clearing flags on attachment: 205287

Committed r151956: <http://trac.webkit.org/changeset/151956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.