Bug 117930 - Update AbstractWorker, Worker and SharedWorker to match the specification
Summary: Update AbstractWorker, Worker and SharedWorker to match the specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://src.chromium.org/viewvc/blink...
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-06-24 05:09 PDT by Chris Dumez
Modified: 2013-06-24 23:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2013-06-24 05:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-24 05:09:43 PDT
Update AbstractWorker, Worker and SharedWorker to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker

Worker and SharedWorker should no longer inherit from AbstractWorker. Web IDL 'implements'
statements should be used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.
Comment 1 Chris Dumez 2013-06-24 05:19:19 PDT
Created attachment 205287 [details]
Patch
Comment 2 Kentaro Hara 2013-06-24 06:40:19 PDT
Comment on attachment 205287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review

> Source/WebCore/workers/AbstractWorker.idl:-36
> -    CustomToJSObject,

Why can you remove this?
Comment 3 Chris Dumez 2013-06-24 07:03:21 PDT
Comment on attachment 205287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205287&action=review

>> Source/WebCore/workers/AbstractWorker.idl:-36
>> -    CustomToJSObject,
> 
> Why can you remove this?

This basically declares the following in JSAbstractWorker.h but don't generate its implementation in JSAbstractWorker.cpp:
JSC::JSValue toJS(JSC::ExecState*, JSDOMGlobalObject*, AbstractWorker*);

It can be removed for 2 reasons:
- Its implementation is not provided anywhere and it likely build only because it is not used.
- Now that AbstractWorker acts as a partial interface, JSAbstractWorker.* are now empty anyway so this attribute would have no impact whatsoever.
Comment 4 Kentaro Hara 2013-06-24 07:48:32 PDT
Comment on attachment 205287 [details]
Patch

Makes sense.
Comment 5 WebKit Commit Bot 2013-06-24 23:28:28 PDT
Comment on attachment 205287 [details]
Patch

Clearing flags on attachment: 205287

Committed r151956: <http://trac.webkit.org/changeset/151956>
Comment 6 WebKit Commit Bot 2013-06-24 23:28:33 PDT
All reviewed patches have been landed.  Closing bug.