Bug 117913 - Refactor line-break checking in RenderLineBlockLayout::nextSegmentBreak
Summary: Refactor line-break checking in RenderLineBlockLayout::nextSegmentBreak
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-22 15:16 PDT by WebKit Commit Bot
Modified: 2022-09-11 13:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.87 KB, patch)
2013-06-23 02:16 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (808.67 KB, application/zip)
2013-06-23 07:38 PDT, Build Bot 		no flags Details
Patch (4.13 KB, patch)
2013-07-04 10:41 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-06-22 15:16:39 PDT 
Remove unnecessary check from RenderLineBlockLayout::nextSegmentBreak
Requested by rhogan on #webkit.
Comment 1 Robert Hogan 2013-06-23 02:16:35 PDT 
Created attachment 205266 [details]
Patch
Comment 2 Build Bot 2013-06-23 07:38:22 PDT 
Comment on attachment 205266 [details]
Patch

Attachment 205266 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/978166

New failing tests:
media/video-frame-accurate-seek.html
Comment 3 Build Bot 2013-06-23 07:38:23 PDT 
Created attachment 205269 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Robert Hogan 2013-07-04 10:41:58 PDT 
Created attachment 206102 [details]
Patch
Comment 5 Ahmad Saleem 2022-09-10 15:41:29 PDT 
Is this something needed now? Thanks!
Comment 6 Alexey Proskuryakov 2022-09-11 13:25:49 PDT 
A refactoring patch that is this old is exceedingly unlikely to apply at this point.