Bug 117907 - "Refactor adding a line break"
Summary: "Refactor adding a line break"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-22 02:58 PDT by WebKit Commit Bot
Modified: 2013-06-24 13:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.73 KB, patch)
2013-06-22 03:05 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-4 for win-future (813.15 KB, application/zip)
2013-06-22 08:33 PDT, Build Bot 		no flags Details
Patch (5.84 KB, patch)
2013-06-24 11:19 PDT, Robert Hogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-06-22 02:58:18 PDT 
"Refactor adding a line break"
Requested by rhogan on #webkit.
Comment 1 Robert Hogan 2013-06-22 03:05:16 PDT 
Created attachment 205243 [details]
Patch
Comment 2 Build Bot 2013-06-22 08:33:35 PDT 
Comment on attachment 205243 [details]
Patch

Attachment 205243 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/971116

New failing tests:
fast/media/mq-transform-03.html
fast/forms/search-event-delay.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 3 Build Bot 2013-06-22 08:33:37 PDT 
Created attachment 205251 [details]
Archive of layout-test-results from APPLE-EWS-4 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-4  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 4 Ryosuke Niwa 2013-06-24 11:03:30 PDT 
Comment on attachment 205243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205243&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2866
> +static inline void addLineBreak(LineWidth& width, InlineIterator& lBreak, RenderObject* object, unsigned offset = 0, int nextBreak = -1)

I feel like this function name is too generic.
commitLineBreakAtCurrentWidth? breakLineAtCurrentWidth or commitCurrentWidthAsLineBreak?
Comment 5 Robert Hogan 2013-06-24 11:19:47 PDT 
Created attachment 205312 [details]
Patch
Comment 6 WebKit Commit Bot 2013-06-24 13:09:51 PDT 
Comment on attachment 205312 [details]
Patch

Clearing flags on attachment: 205312

Committed r151922: <http://trac.webkit.org/changeset/151922>
Comment 7 WebKit Commit Bot 2013-06-24 13:09:54 PDT 
All reviewed patches have been landed.  Closing bug.