Bug 117901 - AX: Make more tests usable on both Windows and Mac
Summary: AX: Make more tests usable on both Windows and Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-21 17:59 PDT by Brent Fulgham
Modified: 2013-06-24 21:09 PDT (History)
12 users (show)

See Also:


Attachments
Patch (27.86 KB, patch)
2013-06-24 11:00 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (495.66 KB, application/zip)
2013-06-24 11:39 PDT, Build Bot
no flags Details
Revised to correct Mac EWS error. (29.39 KB, patch)
2013-06-24 11:48 PDT, Brent Fulgham
cfleizach: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-06-21 17:59:28 PDT
Several of the Accessibility tests use Mac-specific output.  By switching from specific text tokens to our standard layout test text comparison, we can use a single test for both platforms.
Comment 1 Brent Fulgham 2013-06-24 11:00:13 PDT
Created attachment 205310 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2013-06-24 11:00:50 PDT
<rdar://problem/14248148>
Comment 3 Build Bot 2013-06-24 11:39:28 PDT
Comment on attachment 205310 [details]
Patch

Attachment 205310 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/847502

New failing tests:
accessibility/aria-labelledby-overrides-label.html
accessibility/aria-tab-roles.html
Comment 4 Build Bot 2013-06-24 11:39:30 PDT
Created attachment 205314 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 5 Brent Fulgham 2013-06-24 11:48:20 PDT
Created attachment 205315 [details]
Revised to correct Mac EWS error.
Comment 6 chris fleizach 2013-06-24 11:50:32 PDT
Comment on attachment 205315 [details]
Revised to correct Mac EWS error.

great!
Comment 7 Brent Fulgham 2013-06-24 13:47:44 PDT
Committed r151924: <http://trac.webkit.org/changeset/151924>
Comment 8 Benjamin Poulain 2013-06-24 19:25:26 PDT
accessibility/aria-tab-roles.html fails on all Mac bots since this landed: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=aria-tab-roles.html

Can you please have a look?
Comment 9 Brent Fulgham 2013-06-24 21:09:46 PDT
(In reply to comment #8)
> accessibility/aria-tab-roles.html fails on all Mac bots since this landed: http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=aria-tab-roles.html
> 
> Can you please have a look?

I neglected to update the expected output on the Mac.

Committed r151953: <http://trac.webkit.org/changeset/151953>