Bug 117896 - CSS clip property should not force additional clamping to element's border box
Summary: CSS clip property should not force additional clamping to element's border box
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 15:25 PDT by Shawn Singh
Modified: 2022-07-26 10:12 PDT (History)
9 users (show)

See Also:


Attachments
Example of the CSS clip problem (736 bytes, text/html)
2013-06-21 15:26 PDT, Shawn Singh
no flags Details
Patch (8.92 KB, patch)
2013-06-21 15:33 PDT, Shawn Singh
beidson: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-2 for win-future (796.71 KB, application/zip)
2013-06-21 21:44 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2013-06-21 15:25:24 PDT
I've attached a reduced test case, but this is actually already tested by existing layout test compositing/geometry/clip.html which was baselined improperly.  In the attached test case, you should see a small green box on top of the wheat-colored box.   When the wheat box is not composited, it works properly.  When it is composited, the composited layer is clamped to the element's border box, which is incorrect.

Patch coming in a moment.  By the way - It seems that layer-outline-expected.txt and layer-outline-horizontal-expected.txt may need to be rebaselined on other platforms after this change.  Will it be OK to land this and expect someone else to rebaseline them?
Comment 1 Shawn Singh 2013-06-21 15:26:42 PDT
Created attachment 205221 [details]
Example of the CSS clip problem

Example of the CSS clip problem. Small green div should be visible when correct.  (try toggling the translateZ(0) property to make it un-composited, where it works correctly.)
Comment 2 Shawn Singh 2013-06-21 15:33:29 PDT
Created attachment 205222 [details]
Patch
Comment 3 Build Bot 2013-06-21 21:44:56 PDT
Comment on attachment 205222 [details]
Patch

Attachment 205222 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/918724

New failing tests:
fast/media/mq-transform-03.html
fast/forms/search-event-delay.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 4 Build Bot 2013-06-21 21:44:58 PDT
Created attachment 205232 [details]
Archive of layout-test-results from APPLE-EWS-2 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-2  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 5 Simon Fraser (smfr) 2016-01-31 21:10:47 PST
Seems to work now?
Comment 6 Brady Eidson 2016-05-24 22:01:16 PDT
Comment on attachment 205222 [details]
Patch

Assuming that patches for review since 2013 are stale, r-
Comment 7 Ahmad Saleem 2022-07-26 04:35:43 PDT
I am unable to reproduce this issue using attached test case (Example of ..) in Safari 15.6 on macOS 12.5 and it is showing "Green" above square showing clipped text and it matches with all other browsers (Chrome Canary 106 and Firefox Nightly 104), I think it got fixed along the way and this can be marked as "RESOLVED CONFIGURATION CHANGED". If I am testing incorrectly, please retest accordingly. Thanks!