WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117894
GraphicsContext3D including GraphicsContext3DNEON
https://bugs.webkit.org/show_bug.cgi?id=117894
Summary
GraphicsContext3D including GraphicsContext3DNEON
Alex Christensen
Reported
2013-06-21 14:23:08 PDT
Source/WebCore/platform/graphics/GraphicsContext3D.cpp's #including GraphicsContext3DNEON.h causes compiler errors on Windows when enabling WebGL. The header itself is protected with #if HAVE(ARM_NEON_INTRINSICS) and everything in GraphicsContext3D that uses it is also protected with the macro, so I suggest the #include also be protected by this macro.
Attachments
Patch
(1.39 KB, patch)
2013-06-21 14:30 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2013-06-21 14:30:24 PDT
Created
attachment 205218
[details]
Patch
Brent Fulgham
Comment 2
2013-06-21 14:31:24 PDT
Comment on
attachment 205218
[details]
Patch Looks fine. I'm not sure any of the build bots will verify the Neon stuff is ok...
WebKit Commit Bot
Comment 3
2013-06-21 14:56:13 PDT
Comment on
attachment 205218
[details]
Patch Clearing flags on attachment: 205218 Committed
r151858
: <
http://trac.webkit.org/changeset/151858
>
WebKit Commit Bot
Comment 4
2013-06-21 14:56:16 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug