Bug 117894 - GraphicsContext3D including GraphicsContext3DNEON
Summary: GraphicsContext3D including GraphicsContext3DNEON
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-06-21 14:23 PDT by Alex Christensen
Modified: 2013-06-21 14:56 PDT (History)
3 users (show)

See Also:

Patch (1.39 KB, patch)
2013-06-21 14:30 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-21 14:23:08 PDT
Source/WebCore/platform/graphics/GraphicsContext3D.cpp's #including GraphicsContext3DNEON.h causes compiler errors on Windows when enabling WebGL.  The header itself is protected with #if HAVE(ARM_NEON_INTRINSICS) and everything in GraphicsContext3D that uses it is also protected with the macro, so I suggest the #include also be protected by this macro.
Comment 1 Alex Christensen 2013-06-21 14:30:24 PDT
Created attachment 205218 [details]
Comment 2 Brent Fulgham 2013-06-21 14:31:24 PDT
Comment on attachment 205218 [details]

Looks fine.  I'm not sure any of the build bots will verify the Neon stuff is ok...
Comment 3 WebKit Commit Bot 2013-06-21 14:56:13 PDT
Comment on attachment 205218 [details]

Clearing flags on attachment: 205218

Committed r151858: <http://trac.webkit.org/changeset/151858>
Comment 4 WebKit Commit Bot 2013-06-21 14:56:16 PDT
All reviewed patches have been landed.  Closing bug.