Bug 117892 – AX: Title for ListItemRole should consist of concatenated child text elements

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Brent Fulgham]

The accessibility layer perceives ListItemRole elements as blank containers with no title/description.  Firefox renders the same elements using the concatenated text of any child elements.

For example:
<ul>
<li><span class="a">Test A</span><span class="b">1</span></li>
</ul>

The accessibility layer should report this as a List Item named "Test A 1", not "UNNAMED" with children "Test A" and "1".

[Brent Fulgham]

<rdar://problem/14230704>

[Brent Fulgham]

Created attachment 205219 [details]
Patch

[Brent Fulgham]

Created attachment 205225 [details]
Updated with Mac platform results.

[chris fleizach]

Comment on attachment 205225 [details]
Updated with Mac platform results.

View in context: https://bugs.webkit.org/attachment.cgi?id=205225&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

change log says no new tests, but there are

[Brent Fulgham]

Committed r151868: <http://trac.webkit.org/changeset/151868>

[Brent Fulgham]

Comment on attachment 205225 [details]
Updated with Mac platform results.

View in context: https://bugs.webkit.org/attachment.cgi?id=205225&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests (OOPS!).
> 
> change log says no new tests, but there are

Doh!  Fixed.

[Simon Fraser (smfr)]

This seems to have broken a test:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r151868%20(10917)/accessibility/lists-pretty-diff.html

[Brent Fulgham]

(In reply to comment #7)
> This seems to have broken a test:
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r151868%20(10917)/accessibility/lists-pretty-diff.html

Chris: what do you think about this change? The AXGroup is now showing title information due t my recent change to make the list item 'name' be the concatenated child elements text.

I think this new behavior is correct, so this might just need a re-baseline.

[chris fleizach]

(In reply to comment #8)
> (In reply to comment #7)
> > This seems to have broken a test:
> > http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r151868%20(10917)/accessibility/lists-pretty-diff.html
> 
> Chris: what do you think about this change? The AXGroup is now showing title information due t my recent change to make the list item 'name' be the concatenated child elements text.
> 
> I think this new behavior is correct, so this might just need a re-baseline.

I think this is OK to rebaseline as well. It looks like the group representing the list item now has the title of the content inside, which I think is probably the right thing to do anyway

thanks

[Brent Fulgham]

I also placed the new Mac test expectation in the parent folder (above accessibility).  This was corrected in r151913.