Bug 117892 - AX: Title for ListItemRole should consist of concatenated child text elements
Summary: AX: Title for ListItemRole should consist of concatenated child text elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 14:08 PDT by Brent Fulgham
Modified: 2013-06-24 08:36 PDT (History)
9 users (show)

See Also:


Attachments
Patch (3.71 KB, patch)
2013-06-21 14:47 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Updated with Mac platform results. (4.42 KB, patch)
2013-06-21 16:23 PDT, Brent Fulgham
cfleizach: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-06-21 14:08:49 PDT
The accessibility layer perceives ListItemRole elements as blank containers with no title/description.  Firefox renders the same elements using the concatenated text of any child elements.

For example:
<ul>
<li><span class="a">Test A</span><span class="b">1</span></li>
</ul>

The accessibility layer should report this as a List Item named "Test A 1", not "UNNAMED" with children "Test A" and "1".
Comment 1 Brent Fulgham 2013-06-21 14:10:28 PDT
<rdar://problem/14230704>
Comment 2 Brent Fulgham 2013-06-21 14:47:25 PDT
Created attachment 205219 [details]
Patch
Comment 3 Brent Fulgham 2013-06-21 16:23:12 PDT
Created attachment 205225 [details]
Updated with Mac platform results.
Comment 4 chris fleizach 2013-06-21 16:24:46 PDT
Comment on attachment 205225 [details]
Updated with Mac platform results.

View in context: https://bugs.webkit.org/attachment.cgi?id=205225&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

change log says no new tests, but there are
Comment 5 Brent Fulgham 2013-06-21 16:40:13 PDT
Committed r151868: <http://trac.webkit.org/changeset/151868>
Comment 6 Brent Fulgham 2013-06-21 16:47:02 PDT
Comment on attachment 205225 [details]
Updated with Mac platform results.

View in context: https://bugs.webkit.org/attachment.cgi?id=205225&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests (OOPS!).
> 
> change log says no new tests, but there are

Doh!  Fixed.
Comment 8 Brent Fulgham 2013-06-22 22:20:39 PDT
(In reply to comment #7)
> This seems to have broken a test:
> http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r151868%20(10917)/accessibility/lists-pretty-diff.html

Chris: what do you think about this change? The AXGroup is now showing title information due t my recent change to make the list item 'name' be the concatenated child elements text.

I think this new behavior is correct, so this might just need a re-baseline.
Comment 9 chris fleizach 2013-06-22 22:29:15 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > This seems to have broken a test:
> > http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r151868%20(10917)/accessibility/lists-pretty-diff.html
> 
> Chris: what do you think about this change? The AXGroup is now showing title information due t my recent change to make the list item 'name' be the concatenated child elements text.
> 
> I think this new behavior is correct, so this might just need a re-baseline.

I think this is OK to rebaseline as well. It looks like the group representing the list item now has the title of the content inside, which I think is probably the right thing to do anyway

thanks
Comment 10 Brent Fulgham 2013-06-24 08:36:40 PDT
I also placed the new Mac test expectation in the parent folder (above accessibility).  This was corrected in r151913.