Bug 117884 - Update platform text track menu
Summary: Update platform text track menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-21 11:13 PDT by Eric Carlson
Modified: 2013-06-21 13:41 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (4.56 KB, patch)
2013-06-21 11:24 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-06-21 11:13:58 PDT 
Allow a text track menu implemented by the platform media player to have "Off" and "Auto" menu items.
Comment 1 Eric Carlson 2013-06-21 11:24:58 PDT 
Created attachment 205203 [details]
Proposed patch
Comment 2 Jer Noble 2013-06-21 13:00:47 PDT 
Comment on attachment 205203 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205203&action=review

> Source/WebCore/platform/graphics/PlatformTextTrack.h:66
> -    static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient* client, const String& label, const String& language, TrackKind kind, TrackType type)
> +    static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient* client, const String& label, const String& language, TrackKind kind, TrackType type, int uniqueId)
>      {
> -        return adoptRef(new PlatformTextTrack(client, label, language, kind, type));
> +        return adoptRef(new PlatformTextTrack(client, label, language, kind, type, uniqueId));
>      }

This will break the call point in TextTrack.cpp - TextTrack::platformTextTrack(), which does not pass in a uniqueId.  Please update that call before you land.
Comment 3 Eric Carlson 2013-06-21 13:41:18 PDT 
https://trac.webkit.org/r151853