Bug 117874 - HTMLMediaElement should inherit from MediaPlayerClient privately
Summary: HTMLMediaElement should inherit from MediaPlayerClient privately
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
Depends on: 117880
  Show dependency treegraph
Reported: 2013-06-21 06:27 PDT by Allan Sandfeld Jensen
Modified: 2013-06-25 02:00 PDT (History)
7 users (show)

See Also:

Patch (1.99 KB, patch)
2013-06-21 06:30 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2013-06-24 02:50 PDT, Allan Sandfeld Jensen
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-06-21 06:27:13 PDT
HTMLMediaElement was stuck with public inheritance from MediaPlayerClient due to the Chromium port. This can now be fixed to a private inheritance.
Comment 1 Allan Sandfeld Jensen 2013-06-21 06:30:10 PDT
Created attachment 205176 [details]
Comment 2 Andreas Kling 2013-06-21 08:36:44 PDT
Comment on attachment 205176 [details]

Sweet fix!
Comment 3 Allan Sandfeld Jensen 2013-06-21 09:02:18 PDT
Comment on attachment 205176 [details]

Clearing flags on attachment: 205176

Committed r151838: <http://trac.webkit.org/changeset/151838>
Comment 4 Allan Sandfeld Jensen 2013-06-21 09:02:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2013-06-21 09:46:07 PDT
Re-opened since this is blocked by bug 117880
Comment 6 Allan Sandfeld Jensen 2013-06-24 02:50:14 PDT
Created attachment 205280 [details]

Now also fixed MediaPlayerPrivateQt
Comment 7 Allan Sandfeld Jensen 2013-06-25 02:00:53 PDT
Committed r151958: <http://trac.webkit.org/changeset/151958>