RESOLVED FIXED 117864
An element with -webkit-user-select: all should be selected on single click 
https://bugs.webkit.org/show_bug.cgi?id=117864
Summary An element with -webkit-user-select: all should be selected on single click
Ryosuke Niwa
Reported 2013-06-20 22:09:58 PDT
An user should be able to select an element with -webkit-user-select: all with a single click.
Attachments
Fixes the bug (4.61 KB, patch)
2013-06-20 22:22 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixes the bug (7.02 KB, patch)
2013-06-20 22:31 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed non-mac builds (7.10 KB, patch)
2013-06-20 22:32 PDT, Ryosuke Niwa 		darin: review+
darin: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from APPLE-EWS-5 for win-future (812.50 KB, application/zip)
2013-06-21 22:47 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-06-20 22:16:00 PDT
<rdar://problem/13488092>
Ryosuke Niwa
Comment 2 2013-06-20 22:22:10 PDT
Created attachment 205148 [details] Fixes the bug
Early Warning System Bot
Comment 3 2013-06-20 22:26:42 PDT
Comment on attachment 205148 [details] Fixes the bug Attachment 205148 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/960017
Early Warning System Bot
Comment 4 2013-06-20 22:28:01 PDT
Comment on attachment 205148 [details] Fixes the bug Attachment 205148 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/906788
Ryosuke Niwa
Comment 5 2013-06-20 22:31:30 PDT
Created attachment 205149 [details] Fixes the bug
Ryosuke Niwa
Comment 6 2013-06-20 22:32:52 PDT
Created attachment 205150 [details] Fixed non-mac builds
Build Bot
Comment 7 2013-06-21 22:47:31 PDT
Comment on attachment 205150 [details] Fixed non-mac builds Attachment 205150 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/898782 New failing tests: editing/selection/user-select-all-with-single-click.html editing/selection/user-select-all-image-with-single-click.html
Build Bot
Comment 8 2013-06-21 22:47:33 PDT
Created attachment 205234 [details] Archive of layout-test-results from APPLE-EWS-5 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: APPLE-EWS-5 Port: win-future Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Darin Adler
Comment 9 2013-06-28 16:39:13 PDT
Comment on attachment 205150 [details] Fixed non-mac builds View in context: https://bugs.webkit.org/attachment.cgi?id=205150&action=review > Source/WebCore/page/EventHandler.cpp:647 > +#if ENABLE(USERSELECT_ALL) > + return node->canStartSelection() || Position::rootUserSelectAllForNode(node); > +#else > + return node->canStartSelection(); > +#endif Slightly nicer to refactor so we don’t repeat canStartSelection twice.
Ryosuke Niwa
Comment 10 2013-06-28 17:09:40 PDT
Committed r152198: <http://trac.webkit.org/changeset/152198>
Note You need to log in before you can comment on or make changes to this bug.