Bug 117858 - [CMAKE][EFL] Enable DOM4 Events Constructor
Summary: [CMAKE][EFL] Enable DOM4 Events Constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 18:25 PDT by Ryuan Choi
Modified: 2013-06-20 19:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.26 KB, patch)
2013-06-20 18:54 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2013-06-20 18:25:36 PDT 
Patch will be added.
Comment 1 Ryuan Choi 2013-06-20 18:54:52 PDT 
Created attachment 205135 [details]
Patch
Comment 2 Laszlo Gombos 2013-06-20 19:12:51 PDT 
Comment on attachment 205135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205135&action=review

r=me.

> Source/cmake/WebKitFeatures.cmake:50
> +    WEBKIT_OPTION_DEFINE(ENABLE_DOM4_EVENTS_CONSTRUCTOR "Expose DOM4 Events constructors" OFF)

Nit: "Toggle DOM4 Events constructor" to be consistent.
Comment 3 Ryuan Choi 2013-06-20 19:27:22 PDT 
Committed r151815: <http://trac.webkit.org/changeset/151815>
Comment 4 Ryuan Choi 2013-06-20 19:27:58 PDT 
Comment on attachment 205135 [details]
Patch

Thank you.

I landed manually after fixed like you suggested.