Bug 117854 - Refining the StackBounds computation for Windows
Summary: Refining the StackBounds computation for Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 17:13 PDT by Mark Lam
Modified: 2013-08-20 01:49 PDT (History)
10 users (show)

See Also:

Attachments
the patch (4.57 KB, patch)
2013-06-20 17:15 PDT, Mark Lam 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch #2 (4.61 KB, patch)
2013-06-20 17:41 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2013-06-20 17:13:06 PDT 
For Windows, the end of the stack should be at the AllocationBase of the stack's reserved address range.  The end of the useable memory in the stack should be at the end of the address range minus the size of the stack guard page.
Comment 1 Mark Lam 2013-06-20 17:15:31 PDT 
Created attachment 205130 [details]
the patch
Comment 2 EFL EWS Bot 2013-06-20 17:17:53 PDT 
Comment on attachment 205130 [details]
the patch

Attachment 205130 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/857694
Comment 3 Mark Lam 2013-06-20 17:41:00 PDT 
Created attachment 205133 [details]
patch #2
Comment 4 Brent Fulgham 2013-06-20 19:27:16 PDT 
Comment on attachment 205133 [details]
patch #2

Nice simplification! R=me.
Comment 5 WebKit Commit Bot 2013-06-20 19:49:47 PDT 
Comment on attachment 205133 [details]
patch #2

Clearing flags on attachment: 205133

Committed r151817: <http://trac.webkit.org/changeset/151817>
Comment 6 WebKit Commit Bot 2013-06-20 19:49:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Pena 2013-08-20 01:49:19 PDT 
Committed r154318: <http://trac.webkit.org/changeset/154318>