Bug 117846 - [BlackBerry] Send the correct offsets for misspelled words.
Summary: [BlackBerry] Send the correct offsets for misspelled words.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 13:21 PDT by Nima Ghanavatian
Modified: 2013-06-20 15:53 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2013-06-20 13:30 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2013-06-20 13:34 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2013-06-20 13:21:47 PDT 
When the caret is placed after a word, the offsets were calculated around
the proceeding space. As such, words that end a sentence worked correctly, but
midsentence words did not. The 'startOfWord' was calculated for the space ahead
and not for the word before it. Now finding the start of the word correctly and
calculating the end from there.
Comment 1 Nima Ghanavatian 2013-06-20 13:30:51 PDT 
Created attachment 205113 [details]
Patch
Comment 2 Nima Ghanavatian 2013-06-20 13:34:08 PDT 
Created attachment 205114 [details]
Patch
Comment 3 Rob Buis 2013-06-20 13:43:24 PDT 
Comment on attachment 205114 [details]
Patch

LGTM.
Comment 4 WebKit Commit Bot 2013-06-20 15:53:02 PDT 
Comment on attachment 205114 [details]
Patch

Clearing flags on attachment: 205114

Committed r151809: <http://trac.webkit.org/changeset/151809>
Comment 5 WebKit Commit Bot 2013-06-20 15:53:04 PDT 
All reviewed patches have been landed.  Closing bug.