Bug 117830 - HashSet: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
Summary: HashSet: reverse the order of the template arguments at alternate 'find', 'co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-20 05:47 PDT by Mikhail Pozdnyakov
Modified: 2013-06-20 14:10 PDT (History)
14 users (show)

See Also:

Attachments
patch (54.23 KB, patch)
2013-06-20 06:41 PDT, Mikhail Pozdnyakov 		buildbot: commit-queue-
Details | Formatted Diff | Diff
patch v2 (55.08 KB, patch)
2013-06-20 07:29 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2013-06-20 05:47:08 PDT 
We should reverse the order of the template arguments at alternate 'find', 'contains' and 'add' HashSet methods so that callers can just pass the translator and let the compiler deduce T.
Comment 1 Mikhail Pozdnyakov 2013-06-20 06:41:00 PDT 
Created attachment 205082 [details]
patch
Comment 2 Build Bot 2013-06-20 07:18:34 PDT 
Comment on attachment 205082 [details]
patch

Attachment 205082 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/927054
Comment 3 Mikhail Pozdnyakov 2013-06-20 07:29:48 PDT 
Created attachment 205089 [details]
patch v2

fix compilation error on MAC
Comment 4 WebKit Commit Bot 2013-06-20 14:10:22 PDT 
Comment on attachment 205089 [details]
patch v2

Clearing flags on attachment: 205089

Committed r151800: <http://trac.webkit.org/changeset/151800>
Comment 5 WebKit Commit Bot 2013-06-20 14:10:25 PDT 
All reviewed patches have been landed.  Closing bug.