Bug 117828 - [EFL][WK2] Update text checker documentation
Summary: [EFL][WK2] Update text checker documentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks: 117794
  Show dependency tree / graph
 
Reported: 2013-06-20 05:35 PDT by Grzegorz Czajkowski
Modified: 2013-06-20 07:32 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (4.97 KB, patch)
2013-06-20 06:01 PDT, Grzegorz Czajkowski 		cdumez: review-
cdumez: commit-queue-
Details | Formatted Diff | Diff
just update the doc (1.53 KB, patch)
2013-06-20 06:57 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2013-06-20 05:35:04 PDT 
eina_list_free() needs to be to called to free an entire spelling suggestions list. The data contained in the list are already freed.
Comment 1 Grzegorz Czajkowski 2013-06-20 06:01:43 PDT 
Created attachment 205079 [details]
proposed patch
Comment 2 Chris Dumez 2013-06-20 06:27:28 PDT 
Comment on attachment 205079 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304
> +    eina_list_free(loadedLanguages);

I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc?
Comment 3 Ryuan Choi 2013-06-20 06:47:35 PDT 
(In reply to comment #2)
> (From update of attachment 205079 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304
> > +    eina_list_free(loadedLanguages);
> 
> I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc?

+1. 
EINA_LIST_FREE = eina_list_free() + chance to release data.

http://docs.enlightenment.org/stable/eina/group__Eina__List__Group.html#ga608bd2fbf06293a1b794648990703ab4
Comment 4 Grzegorz Czajkowski 2013-06-20 06:57:56 PDT 
Created attachment 205087 [details]
just update the doc
Comment 5 Chris Dumez 2013-06-20 07:03:49 PDT 
Comment on attachment 205087 [details]
just update the doc

View in context: https://bugs.webkit.org/attachment.cgi?id=205087&action=review

LGTM. r=me. with nit.

> Source/WebKit2/UIProcess/API/efl/ewk_text_checker.h:100
> + *         a list and its items will be freed by WebKit.

*the* list and its items...
Comment 6 Grzegorz Czajkowski 2013-06-20 07:12:17 PDT 
Committed r151775: <http://trac.webkit.org/changeset/151775>