Bug 117828 – [EFL][WK2] Update text checker documentation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Grzegorz Czajkowski]

eina_list_free() needs to be to called to free an entire spelling suggestions list. The data contained in the list are already freed.

[Grzegorz Czajkowski]

Created attachment 205079 [details]
proposed patch

[Chris Dumez]

Comment on attachment 205079 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304
> +    eina_list_free(loadedLanguages);

I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc?

[Ryuan Choi]

(In reply to comment #2)
> (From update of attachment 205079 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304
> > +    eina_list_free(loadedLanguages);
> 
> I don't believe this is needed after EINA_LIST_FREE()... We probably just need to update the doc?

+1. 
EINA_LIST_FREE = eina_list_free() + chance to release data.

http://docs.enlightenment.org/stable/eina/group__Eina__List__Group.html#ga608bd2fbf06293a1b794648990703ab4

[Grzegorz Czajkowski]

Created attachment 205087 [details]
just update the doc

[Chris Dumez]

Comment on attachment 205087 [details]
just update the doc

View in context: https://bugs.webkit.org/attachment.cgi?id=205087&action=review

LGTM. r=me. with nit.

> Source/WebKit2/UIProcess/API/efl/ewk_text_checker.h:100
> + *         a list and its items will be freed by WebKit.

*the* list and its items...

[Grzegorz Czajkowski]

Committed r151775: <http://trac.webkit.org/changeset/151775>