Bug 117805 – WebGL needs PLATFORM(WIN) to

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Alex Christensen]

There are many lists of platforms that include a certain file, need a certain definition, etc.  I think it might be better in some cases to specify which platforms do not need a certain definition to make the lists shorter, but for now I'll jump on the band wagon.

[Alex Christensen]

Created attachment 205024 [details]
Patch

[Brent Fulgham]

Comment on attachment 205024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=205024&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.h:777
> +#if PLATFORM(GTK) || PLATFORM(EFL) || USE(CAIRO)

This might be better as PLATFORM(WIN_CAIRO), since GTK and EFL both USE(CAIRO).  Or, we could just make it "#if USE(CAIRO)".

[Build Bot]

Comment on attachment 205024 [details]
Patch

Attachment 205024 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/934402

New failing tests:
fast/frames/seamless/seamless-nested-crash.html

[Build Bot]

Created attachment 205062 [details]
Archive of layout-test-results from APPLE-EWS-6 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-6  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

[WebKit Commit Bot]

Comment on attachment 205024 [details]
Patch

Clearing flags on attachment: 205024

Committed r151805: <http://trac.webkit.org/changeset/151805>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.