Bug 117805 - WebGL needs PLATFORM(WIN) to
Summary: WebGL needs PLATFORM(WIN) to
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
Depends on:
Reported: 2013-06-19 11:43 PDT by Alex Christensen
Modified: 2013-06-20 14:37 PDT (History)
4 users (show)

See Also:

Patch (5.26 KB, patch)
2013-06-19 11:45 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-6 for win-future (798.66 KB, application/zip)
2013-06-20 01:51 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-19 11:43:41 PDT
There are many lists of platforms that include a certain file, need a certain definition, etc.  I think it might be better in some cases to specify which platforms do not need a certain definition to make the lists shorter, but for now I'll jump on the band wagon.
Comment 1 Alex Christensen 2013-06-19 11:45:52 PDT
Created attachment 205024 [details]
Comment 2 Brent Fulgham 2013-06-19 21:03:22 PDT
Comment on attachment 205024 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=205024&action=review

> Source/WebCore/platform/graphics/GraphicsContext3D.h:777

This might be better as PLATFORM(WIN_CAIRO), since GTK and EFL both USE(CAIRO).  Or, we could just make it "#if USE(CAIRO)".
Comment 3 Build Bot 2013-06-20 01:51:41 PDT
Comment on attachment 205024 [details]

Attachment 205024 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/934402

New failing tests:
Comment 4 Build Bot 2013-06-20 01:51:42 PDT
Created attachment 205062 [details]
Archive of layout-test-results from APPLE-EWS-6 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-6  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 5 WebKit Commit Bot 2013-06-20 14:37:32 PDT
Comment on attachment 205024 [details]

Clearing flags on attachment: 205024

Committed r151805: <http://trac.webkit.org/changeset/151805>
Comment 6 WebKit Commit Bot 2013-06-20 14:37:34 PDT
All reviewed patches have been landed.  Closing bug.