Bug 117802 - include generated webgl files in windows
Summary: include generated webgl files in windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-19 10:49 PDT by Alex Christensen
Modified: 2013-06-19 22:04 PDT (History)
2 users (show)

See Also:

Attachments
Patch (35.97 KB, patch)
2013-06-19 10:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (35.82 KB, patch)
2013-06-19 15:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-06-19 10:49:01 PDT 
If WebGL is enabled, the WebGL generated files should be included in the build.  This includes putting them in DerivedSources.cpp and adding the files to the WebCore project and filters without being built directly so they can be easily edited if necessary.
Comment 1 Alex Christensen 2013-06-19 10:55:29 PDT 
Created attachment 205016 [details]
Patch
Comment 2 Alex Christensen 2013-06-19 15:59:11 PDT 
Created attachment 205037 [details]
Patch
Comment 3 Brent Fulgham 2013-06-19 17:51:20 PDT 
Comment on attachment 205037 [details]
Patch

Change looks good to me. R=me.
Comment 4 Brent Fulgham 2013-06-19 21:42:31 PDT 
Comment on attachment 205037 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-06-19 22:04:49 PDT 
Comment on attachment 205037 [details]
Patch

Clearing flags on attachment: 205037

Committed r151768: <http://trac.webkit.org/changeset/151768>
Comment 6 WebKit Commit Bot 2013-06-19 22:04:52 PDT 
All reviewed patches have been landed.  Closing bug.