Bug 117799 - [BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
Summary: [BlackBerry] Prevent loss of tile buffers in BackingStorePrivate::render()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jakob Petsovits
Depends on:
Reported: 2013-06-19 07:55 PDT by Jakob Petsovits
Modified: 2013-06-19 08:30 PDT (History)
5 users (show)

See Also:

Patch (2.38 KB, patch)
2013-06-19 07:59 PDT, Jakob Petsovits
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2013-06-19 07:55:19 PDT
Discovered by Xuefei Ren.                                                                     
If, in rare cases, BackingStorePrivate::renderContents() returns false, the for() loop in render() will take a tile buffer from the surface pool but due to aborting the iteration early, won't put it into the new tile map. In order to prevent losing the buffer, we need to put it back into the surface pool before continuing.

Patch below.
Comment 1 Jakob Petsovits 2013-06-19 07:59:55 PDT
Created attachment 205006 [details]
Comment 2 WebKit Commit Bot 2013-06-19 08:30:47 PDT
Comment on attachment 205006 [details]

Clearing flags on attachment: 205006

Committed r151735: <http://trac.webkit.org/changeset/151735>
Comment 3 WebKit Commit Bot 2013-06-19 08:30:49 PDT
All reviewed patches have been landed.  Closing bug.