Bug 117795 - Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
Summary: Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Blocks: 117787
  Show dependency treegraph
Reported: 2013-06-19 06:20 PDT by Chris Dumez
Modified: 2013-06-19 10:12 PDT (History)
5 users (show)

See Also:

Patch (33.98 KB, patch)
2013-06-19 07:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-19 06:20:12 PDT
The JS bindings generator currently includes JS*Custom.h if [CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used.
This does not seem to be required and it forces the developers to create dummy custom headers. We should probably stop including this header forcefully. The developer can still use [JSCustomHeader] if such inclusion is needed.
Comment 1 Chris Dumez 2013-06-19 07:01:24 PDT
Created attachment 205001 [details]
Comment 2 Kentaro Hara 2013-06-19 07:05:48 PDT
Comment on attachment 205001 [details]

Looks OK.
Comment 3 WebKit Commit Bot 2013-06-19 10:12:43 PDT
Comment on attachment 205001 [details]

Clearing flags on attachment: 205001

Committed r151736: <http://trac.webkit.org/changeset/151736>
Comment 4 WebKit Commit Bot 2013-06-19 10:12:45 PDT
All reviewed patches have been landed.  Closing bug.