WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117795
Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter] is used
https://bugs.webkit.org/show_bug.cgi?id=117795
Summary
Do not require JS*Custom.h header if [CustomPutFunction] / [CustomNamedSetter...
Chris Dumez
Reported
2013-06-19 06:20:12 PDT
The JS bindings generator currently includes JS*Custom.h if [CustomPutFunction] or [CustomNamedSetter] IDL extended attributes are used. This does not seem to be required and it forces the developers to create dummy custom headers. We should probably stop including this header forcefully. The developer can still use [JSCustomHeader] if such inclusion is needed.
Attachments
Patch
(33.98 KB, patch)
2013-06-19 07:01 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2013-06-19 07:01:24 PDT
Created
attachment 205001
[details]
Patch
Kentaro Hara
Comment 2
2013-06-19 07:05:48 PDT
Comment on
attachment 205001
[details]
Patch Looks OK.
WebKit Commit Bot
Comment 3
2013-06-19 10:12:43 PDT
Comment on
attachment 205001
[details]
Patch Clearing flags on attachment: 205001 Committed
r151736
: <
http://trac.webkit.org/changeset/151736
>
WebKit Commit Bot
Comment 4
2013-06-19 10:12:45 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug