Bug 117789 - [Qt][WK2] Add WebKit2 Pointer Lock Implementation
Summary: [Qt][WK2] Add WebKit2 Pointer Lock Implementation
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 118132 118133 118469
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-19 03:52 PDT by Stanislav Pikulik
Modified: 2014-02-03 03:26 PST (History)
23 users (show)

See Also:

Attachments
Patch (196.73 KB, patch)
2013-06-19 04:18 PDT, Stanislav Pikulik 		no flags Details | Formatted Diff | Diff
Patch (194.03 KB, patch)
2013-06-20 05:31 PDT, Stanislav Pikulik 		no flags Details | Formatted Diff | Diff
Patch (195.64 KB, patch)
2013-06-21 08:09 PDT, Stanislav Pikulik 		no flags Details | Formatted Diff | Diff
Patch (197.85 KB, patch)
2013-06-21 08:49 PDT, Stanislav Pikulik 		no flags Details | Formatted Diff | Diff
Patch (197.84 KB, patch)
2013-06-24 04:58 PDT, Stanislav Pikulik 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Pikulik 2013-06-19 03:52:24 PDT 
[Qt][WK2] Add WebKit2 Pointer Lock Implementation
Comment 1 Stanislav Pikulik 2013-06-19 04:18:48 PDT 
Created attachment 204986 [details]
Patch
Comment 2 Stanislav Pikulik 2013-06-19 04:21:24 PDT 
Pointer Lock is currently disabled by macro ENABLE_POINTER_LOCK
Comment 3 Philippe Normand 2013-06-19 06:01:52 PDT 
Please rebase against trunk. New features like this are also announced on webkit-dev usually.
Comment 4 Stanislav Pikulik 2013-06-20 05:31:40 PDT 
Created attachment 205075 [details]
Patch
Comment 5 WebKit Commit Bot 2013-06-20 05:34:52 PDT 
Attachment 205075 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt-5.0-wk2/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/Target.pri', u'Source/WebCore/page/PointerLockController.cpp', u'Source/WebCore/page/PointerLockController.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/DerivedSources.pri', u'Source/WebKit2/Shared/API/c/WKBase.h', u'Source/WebKit2/Shared/APIClientTraits.cpp', u'Source/WebKit2/Shared/APIClientTraits.h', u'Source/WebKit2/Shared/APIObject.h', u'Source/WebKit2/Shared/WebEventConversion.cpp', u'Source/WebKit2/Shared/WebProcessCreationParameters.cpp', u'Source/WebKit2/Shared/WebProcessCreationParameters.h', u'Source/WebKit2/Target.pri', u'Source/WebKit2/UIProcess/API/C/WKAPICast.h', u'Source/WebKit2/UIProcess/API/C/WKContext.cpp', u'Source/WebKit2/UIProcess/API/C/WKContext.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionManager.cpp', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionManager.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionProvider.h', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionRequest.cpp', u'Source/WebKit2/UIProcess/API/C/WKPointerLockPermissionRequest.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h', u'Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h', u'Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp', u'Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_pointerlock.qml', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/pointerlock1.html', u'Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/pointerlock2.html', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequest.cpp', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequest.h', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequestManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/PointerLockPermissionRequestManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockManagerProxy.messages.in', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionManagerProxy.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionManagerProxy.h', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionProvider.cpp', u'Source/WebKit2/UIProcess/PointerLock/WebPointerLockPermissionProvider.h', u'Source/WebKit2/UIProcess/PointerLock/qt/WebPointerLockManagerProxyQt.cpp', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebUIClient.cpp', u'Source/WebKit2/UIProcess/WebUIClient.h', u'Source/WebKit2/UIProcess/qt/QtDialogRunner.h', u'Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp', u'Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h', u'Source/WebKit2/WebKit2.pri', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePointerLockClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePointerLockClient.h', u'Source/WebKit2/WebProcess/PointerLock/PointerLockPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/PointerLockPermissionRequestManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockManager.messages.in', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionCallback.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionCallback.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.cpp', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.h', u'Source/WebKit2/WebProcess/PointerLock/WebPointerLockPermissionManager.messages.in', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/MiniBrowserApplication.cpp', u'Tools/MiniBrowser/qt/qml/BrowserWindow.qml', u'Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp', u'Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp', u'Tools/WebKitTestRunner/InjectedBundle/TestRunner.h', u'Tools/WebKitTestRunner/Target.pri', u'Tools/WebKitTestRunner/TestController.cpp', u'Tools/WebKitTestRunner/TestController.h', u'Tools/WebKitTestRunner/WebPointerLockPermissionProvider.cpp', u'Tools/WebKitTestRunner/WebPointerLockPermissionProvider.h', u'Tools/qmake/mkspecs/features/features.pri']" exit_code: 1
Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:78:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 EFL EWS Bot 2013-06-20 05:38:00 PDT 
Comment on attachment 205075 [details]
Patch

Attachment 205075 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/942507
Comment 7 Build Bot 2013-06-20 05:58:48 PDT 
Comment on attachment 205075 [details]
Patch

Attachment 205075 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/880511
Comment 8 Build Bot 2013-06-20 06:12:16 PDT 
Comment on attachment 205075 [details]
Patch

Attachment 205075 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/951506
Comment 9 Stanislav Pikulik 2013-06-21 08:09:31 PDT 
Created attachment 205185 [details]
Patch
Comment 10 Build Bot 2013-06-21 08:18:14 PDT 
Comment on attachment 205185 [details]
Patch

Attachment 205185 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/937647
Comment 11 Build Bot 2013-06-21 08:18:48 PDT 
Comment on attachment 205185 [details]
Patch

Attachment 205185 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/961112
Comment 12 Stanislav Pikulik 2013-06-21 08:49:16 PDT 
Created attachment 205189 [details]
Patch
Comment 13 WebKit Commit Bot 2013-06-21 08:52:02 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 14 Build Bot 2013-06-21 09:31:30 PDT 
Comment on attachment 205189 [details]
Patch

Attachment 205189 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/884547
Comment 15 Build Bot 2013-06-21 09:46:00 PDT 
Comment on attachment 205189 [details]
Patch

Attachment 205189 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/918602
Comment 16 Stanislav Pikulik 2013-06-24 04:58:34 PDT 
Created attachment 205285 [details]
Patch
Comment 17 Philippe Normand 2013-06-24 08:17:27 PDT 
Please announce this new feature in webkit-dev, as explained in http://www.webkit.org/coding/adding-features.html
Comment 18 Brady Eidson 2013-06-25 09:41:02 PDT 
I think you should break this patch up in to smaller pieces.
Comment 19 Stanislav Pikulik 2013-06-27 07:39:17 PDT 
Ok. I've started breaking up it by submitting 2 patches that contain basics implementations. If/Once they be approved, I'll continue to submit patches with any other changes from this big patch accordingly comments.
Comment 20 Anton Obzhirov 2013-08-23 03:56:01 PDT 
Hi, it seems like we are working on the same feature for different ports. You should check https://bugs.webkit.org/show_bug.cgi?id=99036.
Comment 21 Anders Carlsson 2013-10-02 21:37:35 PDT 
Comment on attachment 205285 [details]
Patch

Qt has been removed, clearing review flags.
Comment 22 Jocelyn Turcotte 2014-02-03 03:26:13 PST 
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.