RESOLVED CONFIGURATION CHANGED 117768
Refactoring: Use specific element types in RenderTextControl* 
https://bugs.webkit.org/show_bug.cgi?id=117768
Summary Refactoring: Use specific element types in RenderTextControl*
Ryosuke Niwa
Reported 2013-06-18 18:51:38 PDT
Consder merging https://chromium.googlesource.com/chromium/blink/+/c435d057894aeca6a9343ebd53ff17425f506ce5 Refactoring: Use specific element types in RenderTextControl*. - RenderTextControl constructor should take HTMLTextFormControlElement as an argument. - RenderTextControlSingleLine constructor should take HTMLInputElement as an argument. - RenderSearchField constructor should take HTMLInputElement as an argument. - RenderTextControlMultiLine constructor should take HTMLTextAreaElement as an argument. Also, simplify updateUserModifyProperty by changing an argument from Node* to HTMLTextFormControlElement*.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-09-30 17:13:24 PDT
Webkit copied CSSPraser from Blink, do we need this anymore? Thanks!
Ahmad Saleem
Comment 2 2022-09-30 17:14:21 PDT
(In reply to Ahmad Saleem from comment #1) > Webkit copied CSSPraser from Blink, do we need this anymore? Thanks! Ignore my comment, realised that the commit link in Comment 0 is incorrect compared to what is asked in this bug.
Alexey Proskuryakov
Comment 3 2022-10-01 09:30:10 PDT
This is all done in WebKit at this point.
Note You need to log in before you can comment on or make changes to this bug.