Bug 117765 - Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms
Summary: Rename functions from Bug 117667 and add safeguards for !ENABLE(VIDEO) platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-18 18:00 PDT by Ruth Fong
Modified: 2013-06-19 17:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.44 KB, patch)
2013-06-18 18:12 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (575.06 KB, application/zip)
2013-06-19 10:56 PDT, WebKit Commit Bot 		no flags Details
Patch (3.47 KB, patch)
2013-06-19 15:53 PDT, Ruth Fong 		beidson: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruth Fong 2013-06-18 18:00:45 PDT 
Tie up loose ends from Bug 117667:
- Rename functions getMediaType() to mediaType()
- Make it work for !ENABLE(VIDEO) platforms
Comment 1 Radar WebKit Bug Importer 2013-06-18 18:01:23 PDT 
<rdar://problem/14197983>
Comment 2 Ruth Fong 2013-06-18 18:12:15 PDT 
Created attachment 204961 [details]
Patch
Comment 3 WebKit Commit Bot 2013-06-19 10:56:39 PDT 
Comment on attachment 204961 [details]
Patch

Rejecting attachment 204961 [details] from commit-queue.

New failing tests:
media/track/media-element-enqueue-event-crash.html
Full output: http://webkit-queues.appspot.com/results/942291
Comment 4 WebKit Commit Bot 2013-06-19 10:56:41 PDT 
Created attachment 205017 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 5 Ruth Fong 2013-06-19 15:53:55 PDT 
Created attachment 205035 [details]
Patch
Comment 6 Ruth Fong 2013-06-19 15:58:54 PDT 
(In reply to comment #4)
> Created an attachment (id=205017) [details]
> Archive of layout-test-results from webkit-cq-02 for mac-mountainlion
> 
> The attached test failures were seen while running run-webkit-tests on the commit-queue.
> Bot: webkit-cq-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.3

I ran the specific failing test on Mac OS X 10.8.4 and it ran as expected - not sure if this was an issue with commit-queue.
Comment 7 Ruth Fong 2013-06-19 17:17:30 PDT 
Tim Horton landed the patch: http://trac.webkit.org/changeset/151760
Comment 8 Ruth Fong 2013-06-19 17:24:04 PDT 
The reason commit-queue was failing is due to an unhandled null case in TextTrackCue::cueIndex(). 

Bug 117815 is tracking this issue.