Bug 117761 - [Windows] AX: Extend notification support
Summary: [Windows] AX: Extend notification support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks: 38882
  Show dependency tree / graph
 
Reported: 2013-06-18 15:38 PDT by Brent Fulgham
Modified: 2013-06-19 11:49 PDT (History)
10 users (show)

See Also:

Attachments
Patch (9.25 KB, patch)
2013-06-19 09:52 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-06-18 15:38:05 PDT 
Continue the IAccessible2 interface support:
1. Hook up some missing Document notification handlers.
2. Provide 'press' implementation in DumpRenderTree so press events can be handled.
Comment 1 Brent Fulgham 2013-06-18 15:40:44 PDT 
This is also related to <rdar://problem/9524530>
Comment 2 Brent Fulgham 2013-06-19 09:52:41 PDT 
Created attachment 205013 [details]
Patch
Comment 3 WebKit Commit Bot 2013-06-19 09:54:00 PDT 
Attachment 205013 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1
Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brent Fulgham 2013-06-19 11:08:19 PDT 
(In reply to comment #3)
> Attachment 205013 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1
> Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
> Total errors found: 2 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

To avoid the stylebot warning, I would have to reformat the entire switch statement. I'm ignoring this style suggestion.
Comment 5 Brent Fulgham 2013-06-19 11:46:13 PDT 
Comment on attachment 205013 [details]
Patch

Clearing flags on attachment: 205013

Committed r151745: <http://trac.webkit.org/changeset/151745>
Comment 6 Brent Fulgham 2013-06-19 11:46:15 PDT 
All reviewed patches have been landed.  Closing bug.