Bug 117761 – [Windows] AX: Extend notification support

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Brent Fulgham]

Continue the IAccessible2 interface support:
1. Hook up some missing Document notification handlers.
2. Provide 'press' implementation in DumpRenderTree so press events can be handled.

[Brent Fulgham]

This is also related to <rdar://problem/9524530>

[Brent Fulgham]

Created attachment 205013 [details]
Patch

[WebKit Commit Bot]

Attachment 205013 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1
Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

(In reply to comment #3)
> Attachment 205013 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/win/AXObjectCacheWin.cpp', u'Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebKit/win/AccessibleDocument.cpp', u'Source/WebKit/win/AccessibleDocument.h', u'Source/WebKit/win/ChangeLog', u'Tools/ChangeLog', u'Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp']" exit_code: 1
> Tools/DumpRenderTree/win/AccessibilityUIElementWin.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
> Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:81:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
> Total errors found: 2 in 10 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

To avoid the stylebot warning, I would have to reformat the entire switch statement. I'm ignoring this style suggestion.

[Brent Fulgham]

Comment on attachment 205013 [details]
Patch

Clearing flags on attachment: 205013

Committed r151745: <http://trac.webkit.org/changeset/151745>

[Brent Fulgham]

All reviewed patches have been landed.  Closing bug.