Bug 117758 - Make it possible to set a minimum height for auto-layout
Summary: Make it possible to set a minimum height for auto-layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-18 14:48 PDT by Anders Carlsson
Modified: 2013-06-18 15:02 PDT (History)
1 user (show)

See Also:

Attachments
Patch (23.07 KB, patch)
2013-06-18 14:50 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-06-18 14:48:21 PDT 
Make it possible to set a minimum height for auto-layout
Comment 1 Anders Carlsson 2013-06-18 14:50:44 PDT 
Created attachment 204946 [details]
Patch
Comment 2 Tim Horton 2013-06-18 14:53:12 PDT 
Comment on attachment 204946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204946&action=review

> Source/WebKit2/ChangeLog:50
> +        * Shared/WebPageCreationParameters.cpp:
> +        (WebKit::WebPageCreationParameters::encode):
> +        (WebKit::WebPageCreationParameters::decode):
> +        * Shared/WebPageCreationParameters.h:
> +        * UIProcess/API/mac/WKView.mm:
> +        (-[WKView _setIntrinsicContentSize:]):
> +        (-[WKView minimumLayoutWidth]):
> +        (-[WKView setMinimumLayoutWidth:]):
> +        (-[WKView minimumWidthForAutoLayout]):
> +        (-[WKView setMinimumWidthForAutoLayout:]):
> +        (-[WKView minimumSizeForAutoLayout]):
> +        (-[WKView setMinimumSizeForAutoLayout:]):
> +        * UIProcess/API/mac/WKViewPrivate.h:
> +        * UIProcess/DrawingAreaProxy.h:
> +        (WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):
> +        * UIProcess/WebPageProxy.cpp:
> +        (WebKit::WebPageProxy::WebPageProxy):
> +        (WebKit::WebPageProxy::creationParameters):
> +        (WebKit::WebPageProxy::setMinimumLayoutSize):
> +        * UIProcess/WebPageProxy.h:
> +        (WebKit::WebPageProxy::minimumLayoutSize):
> +        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
> +        * UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
> +        (WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
> +        (WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
> +        (WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
> +        (WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
> +        (WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
> +        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
> +        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
> +        * WebProcess/WebPage/WebPage.cpp:
> +        (WebKit::WebPage::WebPage):
> +        (WebKit::WebPage::setMinimumLayoutSize):
> +        * WebProcess/WebPage/WebPage.h:
> +        (WebKit::WebPage::minimumLayoutSize):
> +        * WebProcess/WebPage/WebPage.messages.in:
> +        * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
> +        (WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
> +        (WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

Yikes.
Comment 3 WebKit Commit Bot 2013-06-18 14:54:01 PDT 
Attachment 204946 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPageCreationParameters.cpp', u'Source/WebKit2/Shared/WebPageCreationParameters.h', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h', u'Source/WebKit2/UIProcess/DrawingAreaProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h', u'Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm']" exit_code: 1
Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2013-06-18 15:02:04 PDT 
Committed r151701: <http://trac.webkit.org/changeset/151701>