Bug 117746 - Web Inspector: REGRESSION: Attempting to select a breakpoint in the Debugger sidebar selects the Resource
Summary: Web Inspector: REGRESSION: Attempting to select a breakpoint in the Debugger ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2013-06-18 12:01 PDT by Timothy Hatcher
Modified: 2013-06-20 06:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.03 KB, patch)
2013-06-18 12:14 PDT, Timothy Hatcher
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-06-18 12:01:13 PDT
I think this is a recent regression related to tieing ContentViews with particular Sidebars. Following the steps to reproduce I select a breakpoint and I would expect that breakpoint to be selected after the click. Instead the inspector makes the resource the breakpoint belongs to selected.

Steps:
1. Inspect <http://pecoraro.apple.com/source-map-tests/reasonable-example/>
2. Set a breakpoint in SourceMapResource script-1.js:14
3. Switch to the Debugger sidebar
4. Reload the page
  => content view switches to the DOM content view, I'd expect it to keep showing the Script
5. Select the Breakpoint
  => sidebar selects the script resource instead of the breakpoint I just clicked on

<rdar://problem/14090263>
Comment 1 Timothy Hatcher 2013-06-18 12:14:51 PDT
Created attachment 204928 [details]
Patch
Comment 2 Joseph Pecoraro 2013-06-18 12:20:37 PDT
Comment on attachment 204928 [details]
Patch

r=me. Seems a little obtuse, but it looks fine to me.
Comment 3 Timothy Hatcher 2013-06-20 06:18:32 PDT
http://trac.webkit.org/changeset/151688